linux-kernel - Re: [PATCH v7 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250828155412.2b1b2095125428af24896af5@linux-foundation.org>
Date: Thu, 28 Aug 2025 15:54:12 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: "Liam R. Howlett" <Liam.Howlett@...cle.com>
Cc: Brendan Jackman <jackmanb@...gle.com>, Ujwal Kundur
 <ujwal.kundur@...il.com>, peterx@...hat.com, david@...hat.com,
 lorenzo.stoakes@...cle.com, vbabka@...e.cz, rppt@...nel.org,
 surenb@...gle.com, mhocko@...e.com, shuah@...nel.org, linux-mm@...ck.org,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org, Muhammad
 Usama Anjum <usama.anjum@...labora.com>
Subject: Re: [PATCH v7 1/1] selftests/mm/uffd: Refactor non-composite global
 vars into struct

On Thu, 28 Aug 2025 14:49:37 -0400 "Liam R. Howlett" <Liam.Howlett@...cle.com> wrote:

> * Brendan Jackman <jackmanb@...gle.com> [250828 08:37]:
> > On Sun Aug 17, 2025 at 6:52 AM UTC, Ujwal Kundur wrote:
> > > -static void noop_alias_mapping(__u64 __unused *start, size_t __unused len,
> > > -			       unsigned long __unused offset)
> > > +static void noop_alias_mapping(uffd_global_test_opts_t *gopts, __u64 __unused *start,
> > > +			       size_t __unused len, unsigned long __unused offset)
> > 
> > After a rebase this is now falling afoul of the -Wunused-parameter added
> > here:
> > 
> > https://lore.kernel.org/all/20250731160132.1795351-5-usama.anjum@collabora.com/T/#m0449dc0d6a5ac3b1f71f7182c13b6829e1b444cf
> > 
> > I really don't think we want that flag, I'll comment on that thread, but
> > just as an FYI here too.
> 
> I was under the impression that it was decided to drop that flag,
> otherwise I would have also spoken up about it.

err, yes, I thought I'd dropped that.

No -Wunused-parameter, please.

The v2 series needs work and a v3 series is expected so I'll drop the
v2 series "selftests/mm: Add compiler flags and fix found warnings".