linux-kernel - Re: [PATCH v7 1/8] sched/fair: Get rid of sched_domains_curr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <932003e8783cd73c9303044ee17efdad5e3cbd8d.camel@linux.intel.com>
Date: Thu, 28 Aug 2025 16:06:37 -0700
From: Tim Chen <tim.c.chen@...ux.intel.com>
To: K Prateek Nayak <kprateek.nayak@....com>, Madhavan Srinivasan
 <maddy@...ux.ibm.com>, Michael Ellerman <mpe@...erman.id.au>, Nicholas
 Piggin <npiggin@...il.com>, Christophe Leroy <christophe.leroy@...roup.eu>,
 Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
 Alexander Gordeev <agordeev@...ux.ibm.com>, Christian Borntraeger
 <borntraeger@...ux.ibm.com>,  Sven Schnelle <svens@...ux.ibm.com>, Thomas
 Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,  Borislav
 Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
 x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>, Peter Zijlstra
 <peterz@...radead.org>, Juri Lelli <juri.lelli@...hat.com>, Vincent Guittot
 <vincent.guittot@...aro.org>,  linuxppc-dev@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org,  linux-s390@...r.kernel.org
Cc: Dietmar Eggemann <dietmar.eggemann@....com>, Steven Rostedt
 <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>, Mel Gorman
 <mgorman@...e.de>, Valentin Schneider <vschneid@...hat.com>, 
 thomas.weissschuh@...utronix.de, Li Chen <chenl311@...natelecom.cn>, Bibo
 Mao <maobibo@...ngson.cn>, Mete Durlu <meted@...ux.ibm.com>, Tobias Huschle
 <huschle@...ux.ibm.com>, Easwar Hariharan
 <easwar.hariharan@...ux.microsoft.com>,  Guo Weikang
 <guoweikang.kernel@...il.com>, "Rafael J. Wysocki"
 <rafael.j.wysocki@...el.com>, Brian Gerst <brgerst@...il.com>, Patryk
 Wlazlyn <patryk.wlazlyn@...ux.intel.com>,  Swapnil Sapkal
 <swapnil.sapkal@....com>, "Yury Norov [NVIDIA]" <yury.norov@...il.com>,
 Sudeep Holla <sudeep.holla@....com>, Jonathan Cameron
 <Jonathan.Cameron@...wei.com>,  Andrea Righi <arighi@...dia.com>, Yicong
 Yang <yangyicong@...ilicon.com>, Ricardo Neri
 <ricardo.neri-calderon@...ux.intel.com>, Vinicius Costa Gomes
 <vinicius.gomes@...el.com>
Subject: Re: [PATCH v7 1/8] sched/fair: Get rid of sched_domains_curr_level
 hack for tl->cpumask()

On Tue, 2025-08-26 at 04:13 +0000, K Prateek Nayak wrote:
> From: Peter Zijlstra <peterz@...radead.org>
> 
> 
...snip...

>  
> -static const struct cpumask *cpu_mc_mask(int cpu)
> +static const struct cpumask *cpu_mc_mask(struct sched_domain_topology_level *tl, int cpu)
>  {
>  	return cpu_coregroup_mask(cpu);
>  }
>  
> +static const struct cpumask *cpu_pkg_mask(struct sched_domain_topology_level *tl, int cpu)
> +{
> +	return cpu_node_mask(cpu);
> +}
> +

I suggest that we rename this function as tl_node_mask as we are
returning the node mask.  We could have multiple nodes in a package
for SNC and it may not actually be pkg_mask for such case.

Rest of the patch looks good.

Thanks.

Tim