linux-kernel - Re: [PATCH kvm-next V11 4/7] KVM: guest_memfd: Use guest mem inodes instead of anonymous inodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79fae787-7160-4245-886f-671860b5708a@amd.com>
Date: Thu, 28 Aug 2025 11:19:42 +0530
From: "Garg, Shivank" <shivankg@....com>
To: Ackerley Tng <ackerleytng@...gle.com>, willy@...radead.org,
 akpm@...ux-foundation.org, david@...hat.com, pbonzini@...hat.com,
 shuah@...nel.org, seanjc@...gle.com, vbabka@...e.cz
Cc: brauner@...nel.org, viro@...iv.linux.org.uk, dsterba@...e.com,
 xiang@...nel.org, chao@...nel.org, jaegeuk@...nel.org, clm@...com,
 josef@...icpanda.com, kent.overstreet@...ux.dev, zbestahu@...il.com,
 jefflexu@...ux.alibaba.com, dhavale@...gle.com, lihongbo22@...wei.com,
 lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com, rppt@...nel.org,
 surenb@...gle.com, mhocko@...e.com, ziy@...dia.com, matthew.brost@...el.com,
 joshua.hahnjy@...il.com, rakie.kim@...com, byungchul@...com,
 gourry@...rry.net, ying.huang@...ux.alibaba.com, apopple@...dia.com,
 tabba@...gle.com, paul@...l-moore.com, jmorris@...ei.org, serge@...lyn.com,
 pvorel@...e.cz, bfoster@...hat.com, vannapurve@...gle.com,
 chao.gao@...el.com, bharata@....com, nikunj@....com, shdhiman@....com,
 yan.y.zhao@...el.com, Neeraj.Upadhyay@....com, thomas.lendacky@....com,
 michael.roth@....com, aik@....com, jgg@...dia.com, kalyazin@...zon.com,
 peterx@...hat.com, jack@...e.cz, hch@...radead.org, cgzones@...glemail.com,
 ira.weiny@...el.com, rientjes@...gle.com, roypat@...zon.co.uk,
 chao.p.peng@...el.com, amit@...radead.org, ddutile@...hat.com,
 dan.j.williams@...el.com, ashish.kalra@....com, gshan@...hat.com,
 jgowans@...zon.com, pankaj.gupta@....com, papaluri@....com,
 yuzhao@...gle.com, suzuki.poulose@....com, linux-bcachefs@...r.kernel.org,
 linux-btrfs@...r.kernel.org, linux-erofs@...ts.ozlabs.org,
 linux-f2fs-devel@...ts.sourceforge.net, linux-fsdevel@...r.kernel.org,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 linux-security-module@...r.kernel.org, kvm@...r.kernel.org,
 linux-kselftest@...r.kernel.org, linux-coco@...ts.linux.dev
Subject: Re: [PATCH kvm-next V11 4/7] KVM: guest_memfd: Use guest mem inodes
 instead of anonymous inodes



On 8/28/2025 4:13 AM, Ackerley Tng wrote:
> Shivank Garg <shivankg@....com> writes:
> 
>>
>> [...snip...]
>>
> 
> I meant to send this to you before this version went out but you were
> too quick!

I wanted to get it merged quickly ;)

> 
> Here's a new version, Fuad and I reviewed this again internally. The
> changes are:
> 
> + Sort linux/pseudo_fs.h after linux/pagemap.h (alphabetical)
> + Don't set MNT_NOEXEC on the mount, since SB_I_NOEXEC was already set
>   on the superblock
> + Rename kvm_gmem_inode_make_secure_inode() to kvm_gmem_inode_create()
>     + Emphasizes that there is a creation in this function
>     + Remove "secure" from the function name to remove confusion that
>       there may be a "non-secure" version
> + In kvm_gmem_inode_create_getfile()'s error path, return ERR_PTR(err)
>   directly instead of having a goto
>

Thanks for the quick update! The changes look good. I'll incorporate them
in the next version.

Best Regards,
Shivank