linux-kernel - 回复: [PATCH 3/3] arm64: dts: cix: Add pinctrl nodes for sky1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PUZPR06MB5887E5164D22D5E42D1442F9EF3BA@PUZPR06MB5887.apcprd06.prod.outlook.com>
Date: Thu, 28 Aug 2025 06:14:06 +0000
From: Gary Yang <gary.yang@...tech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, "linus.walleij@...aro.org"
	<linus.walleij@...aro.org>, "robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>
CC: "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	cix-kernel-upstream <cix-kernel-upstream@...tech.com>
Subject:
 回复: [PATCH 3/3] arm64: dts: cix: Add pinctrl nodes for sky1

Hi Krzysztof,

> On 27/08/2025 04:42, Gary Yang wrote:
> >                       };
> >               };
> > +
> > +             iomuxc: pinctrl@...0000 {
> > +                     compatible = "cix,sky1-iomuxc";
> > +                     reg = <0x0 0x04170000 0x0 0x1000>;
> > +             };
> > +
> > +             iomuxc_s5: pinctrl@...07000 {
> 
> Are you sure you follow DTS coding style for ordering of nodes? Looks like you
> just keep adding things to the end...

Sorry, I see, we will correct it next version. Thanks for your comments

> 
> > +                     compatible = "cix,sky1-iomuxc-s5";
> > +                     reg = <0x0 0x16007000 0x0 0x1000>;
> > +             };
> >       };
> >
> >       timer {
> 
> 
> Best regards,
> Krzysztof

Best wishes
Gary