linux-kernel - Re: [PATCH 03/24] MIPS: PCI: Use pci_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aK_93U_PnpKayqZD@alpha.franken.de>
Date: Thu, 28 Aug 2025 08:57:33 +0200
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Andreas Larsson <andreas@...sler.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	linux-m68k@...ts.linux-m68k.org, linux-mips@...r.kernel.org,
	linux-pci@...r.kernel.org, sparclinux@...r.kernel.org,
	Christian König <christian.koenig@....com>,
	Yinghai Lu <yinghai@...nel.org>,
	Igor Mammedov <imammedo@...hat.com>,
	"Rafael J . Wysocki" <rafael@...nel.org>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
	Krzysztof Wilczyński <kw@...ux.com>,
	linux-kernel@...r.kernel.org,
	Michał Winiarski <michal.winiarski@...el.com>,
	linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 03/24] MIPS: PCI: Use pci_enable_resources()

On Fri, Aug 22, 2025 at 05:55:44PM +0300, Ilpo Järvinen wrote:
> pci-legacy.c under MIPS has a copy of pci_enable_resources() named as
> pcibios_enable_resources(). Having own copy of same functionality could
> lead to inconsistencies in behavior, especially now as
> pci_enable_resources() and the bridge window resource flags behavior
> are going to be altered by upcoming changes.
> 
> The check for !r->start && r->end is already covered by the more
> generic checks done in pci_enable_resources().
> 
> Call pci_enable_resources() from MIPS's pcibios_enable_device() and
> remove pcibios_enable_resources().
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---
>  arch/mips/pci/pci-legacy.c | 38 ++------------------------------------
>  1 file changed, 2 insertions(+), 36 deletions(-)

Acked-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]