linux-kernel - Re: [PATCH v1] usb: typec: tcpm: properly deliver cable vdms to altmode drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aLAUetrP3zKg9kg6@kuha.fi.intel.com>
Date: Thu, 28 Aug 2025 11:34:02 +0300
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: RD Babiera <rdbabiera@...gle.com>
Cc: gregkh@...uxfoundation.org, badhri@...gle.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH v1] usb: typec: tcpm: properly deliver cable vdms to
 altmode drivers

On Thu, Aug 21, 2025 at 08:37:57PM +0000, RD Babiera wrote:
> tcpm_handle_vdm_request delivers messages to the partner altmode or the
> cable altmode depending on the SVDM response type, which is incorrect.
> The partner or cable should be chosen based on the received message type
> instead.
> 
> Also add this filter to ADEV_NOTIFY_USB_AND_QUEUE_VDM, which is used when
> the Enter Mode command is responded to by a NAK on SOP or SOP' and when
> the Exit Mode command is responded to by an ACK on SOP.
> 
> Fixes: 7e7877c55eb1 ("usb: typec: tcpm: add alt mode enter/exit/vdm support for sop'")
> Cc: stable@...r.kernel.org
> Signed-off-by: RD Babiera <rdbabiera@...gle.com>
> Reviewed-by: Badhri Jagan Sridharan <badhri@...gle.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/tcpm/tcpm.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 1f6fdfaa34bf..b2a568a5bc9b 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -2426,17 +2426,21 @@ static void tcpm_handle_vdm_request(struct tcpm_port *port,
>  		case ADEV_NONE:
>  			break;
>  		case ADEV_NOTIFY_USB_AND_QUEUE_VDM:
> -			WARN_ON(typec_altmode_notify(adev, TYPEC_STATE_USB, NULL));
> -			typec_altmode_vdm(adev, p[0], &p[1], cnt);
> +			if (rx_sop_type == TCPC_TX_SOP_PRIME) {
> +				typec_cable_altmode_vdm(adev, TYPEC_PLUG_SOP_P, p[0], &p[1], cnt);
> +			} else {
> +				WARN_ON(typec_altmode_notify(adev, TYPEC_STATE_USB, NULL));
> +				typec_altmode_vdm(adev, p[0], &p[1], cnt);
> +			}
>  			break;
>  		case ADEV_QUEUE_VDM:
> -			if (response_tx_sop_type == TCPC_TX_SOP_PRIME)
> +			if (rx_sop_type == TCPC_TX_SOP_PRIME)
>  				typec_cable_altmode_vdm(adev, TYPEC_PLUG_SOP_P, p[0], &p[1], cnt);
>  			else
>  				typec_altmode_vdm(adev, p[0], &p[1], cnt);
>  			break;
>  		case ADEV_QUEUE_VDM_SEND_EXIT_MODE_ON_FAIL:
> -			if (response_tx_sop_type == TCPC_TX_SOP_PRIME) {
> +			if (rx_sop_type == TCPC_TX_SOP_PRIME) {
>  				if (typec_cable_altmode_vdm(adev, TYPEC_PLUG_SOP_P,
>  							    p[0], &p[1], cnt)) {
>  					int svdm_version = typec_get_cable_svdm_version(
> 
> base-commit: 956606bafb5fc6e5968aadcda86fc0037e1d7548
> -- 
> 2.51.0.261.g7ce5a0a67e-goog

-- 
heikki