linux-kernel - [PATCH v5 0/2] PCI/AER: Handle Advisory Non-Fatal error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250828010016.5824-1-mattc@purestorage.com>
Date: Wed, 27 Aug 2025 19:00:16 -0600
From: Matthew W Carlis <mattc@...estorage.com>
To: helgaas@...nel.org
Cc: Smita.KoralahalliChannabasappa@....com,
	adam.c.preble@...el.com,
	agovindjee@...estorage.com,
	alison.schofield@...el.com,
	ashishk@...estorage.com,
	bamstadt@...estorage.com,
	bhelgaas@...gle.com,
	bp@...en8.de,
	chao.p.peng@...el.com,
	dan.j.williams@...el.com,
	dave.jiang@...el.com,
	dave@...olabs.net,
	erwin.tsaur@...el.com,
	feiting.wanyan@...el.com,
	ira.weiny@...el.com,
	james.morse@....com,
	jrangi@...estorage.com,
	lenb@...nel.org,
	linux-acpi@...r.kernel.org,
	linux-cxl@...r.kernel.org,
	linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org,
	lukas@...ner.de,
	mahesh@...ux.ibm.com,
	mattc@...estorage.com,
	msaggi@...estorage.com,
	oohall@...il.com,
	qingshun.wang@...ux.intel.com,
	rafael@...nel.org,
	rhan@...estorage.com,
	rrichter@....com,
	sathyanarayanan.kuppuswamy@...el.com,
	sconnor@...estorage.com,
	tony.luck@...el.com,
	vishal.l.verma@...el.com,
	yudong.wang@...el.com,
	zhenzhong.duan@...el.com
Subject: [PATCH v5 0/2] PCI/AER: Handle Advisory Non-Fatal error

On Fri, 22 Aug 2025 11:51:12 -0500, Bjorn Helgaas wrote 
> Matthew, if you are able to test and/or provide a Reviewed-by, that would
> be the best thing you can do to move this forward ...

I spent some time looking at the patch thinking about it a little
more carefully. The only thing I don't really like in this revision
of the patch is the logging for "may cause Advisory". Example below
from "[PATCH v5 2/2] PCI/AER: Print UNCOR_STATUS bits that might be ANFE".

AER: Correctable error message received from 0000:b7:02.0
PCIe Bus Error: severity=Correctable, type=Transaction Layer, (Receiver ID)
  device [8086:0db0] error status/mask=00002000/00000000
   [13] NonFatalErr
  Uncorrectable errors that may cause Advisory Non-Fatal:
   [12] TLP

I don't think we really need to log the UE caused by ANF any differently
than any other UE & in fact I would prefer not to. In my mind we should log all
the UE status bits via the same format as before. Taking from example above,
in my mind it would be nice if the logging looked like this.

AER: Correctable error message received from 0000:b7:02.0
PCIe Bus Error: severity=Correctable, type=Transaction Layer, (Receiver ID)
  device [8086:0db0] error status/mask=00002000/00000000
   [13] NonFatalErr
PCIe Bus Error: severity=Uncorrectable (Non-Fatal), type=Transaction Layer
   [12] TLP

If there was only one error (that triggered ANF handling) then we would
know that the Non-Fatal UE was what triggered the NonFatalErr. If some other
Non-Fatal errors are happening at the same time then it doesn't really matter
which was sent via ERR_COR vs ERR_NONFATAL since we would also know from Root
Error Status that we had received at least one of each message type. The
objective in my mind being to free up header-logs & log status details without
making error the recovery worse.

Does this sound reasonable or unreasonable? I can update the patch-set &
re-submit if 'reasonable'.

Cheers!
-Matt