linux-kernel - RE: [PATCH] scsi: ufs: exynos: fsd: Gate ref_clk and put UFS device in reset on suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <005401dc1804$d68d9110$83a8b330$@samsung.com>
Date: Thu, 28 Aug 2025 15:46:24 +0530
From: "Bharat Uppal" <bharat.uppal@...sung.com>
To: "'Bart Van Assche'" <bvanassche@....org>, <linux-scsi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <James.Bottomley@...senPartnership.com>,
	<martin.petersen@...cle.com>, <alim.akhtar@...sung.com>,
	<avri.altman@....com>, <linux-samsung-soc@...r.kernel.org>
Cc: <pankaj.dubey@...sung.com>, <aswani.reddy@...sung.com>, "'Nimesh Sati'"
	<nimesh.sati@...sung.com>, <bharat.uppal@...sung.com>
Subject: RE: [PATCH] scsi: ufs: exynos: fsd: Gate ref_clk and put UFS device
 in reset on suspend

Hi Bart,
I have made the relevant changes and pushed the updated patch.
Can you please review it and close the same.

With Regards
Bharat Uppal

> -----Original Message-----
> From: Bharat Uppal <bharat.uppal@...sung.com>
> Sent: 05 August 2025 10:58
> To: 'Bart Van Assche' <bvanassche@....org>; 'linux-scsi@...r.kernel.org'
> <linux-scsi@...r.kernel.org>; 'linux-kernel@...r.kernel.org' <linux-
> kernel@...r.kernel.org>; 'James.Bottomley@...senPartnership.com'
> <James.Bottomley@...senPartnership.com>;
> 'martin.petersen@...cle.com' <martin.petersen@...cle.com>;
> 'alim.akhtar@...sung.com' <alim.akhtar@...sung.com>;
> 'avri.altman@....com' <avri.altman@....com>; 'linux-samsung-
> soc@...r.kernel.org' <linux-samsung-soc@...r.kernel.org>
> Cc: 'pankaj.dubey@...sung.com' <pankaj.dubey@...sung.com>;
> 'aswani.reddy@...sung.com' <aswani.reddy@...sung.com>; 'Nimesh Sati'
> <nimesh.sati@...sung.com>
> Subject: RE: [PATCH] scsi: ufs: exynos: fsd: Gate ref_clk and put UFS device in
> reset on suspend
> 
> 
> > -----Original Message-----
> > From: Bart Van Assche <bvanassche@....org>
> > Sent: 04 August 2025 21:17
> > To: Bharat Uppal <bharat.uppal@...sung.com>;
> > linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org;
> > James.Bottomley@...senPartnership.com;
> > martin.petersen@...cle.com; alim.akhtar@...sung.com;
> > avri.altman@....com; linux-samsung-soc@...r.kernel.org
> > Cc: pankaj.dubey@...sung.com; aswani.reddy@...sung.com; Nimesh
> Sati
> > <nimesh.sati@...sung.com>
> > Subject: Re: [PATCH] scsi: ufs: exynos: fsd: Gate ref_clk and put UFS
> > device in reset on suspend
> >
> > On 8/4/25 4:36 AM, Bharat Uppal wrote:
> > > +static int fsd_ufs_suspend(struct exynos_ufs *ufs) {
> > > +	exynos_ufs_gate_clks(ufs);
> > > +	hci_writel(ufs, 0 << 0, HCI_GPIO_OUT);
> > > +	return 0;
> > > +}
> >
> > Why '0 << 0' instead of just '0'? Isn't the latter easier to read?
> Thanks for reviewing.
> Indeed setting 0 is right, but in the same file ufs-exynos.c,  I have seen
> HCI_GPIO_OUT register configured using 0 << 0.
> My intent here is to maintain coding style within the file.
> 
> With Regards
> Bharat Uppal
> 
> >
> > Thanks,
> >
> > Bart.