linux-kernel - Re: [PATCH v2] arm64: dts: rockchip: Enables sound output from the audio jack on OrangePI5 Plus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9820114.4vTCxPXJkl@phil>
Date: Thu, 28 Aug 2025 14:04:43 +0200
From: Heiko Stuebner <heiko@...ech.de>
To: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Hide Hako <opi5plus@....bai.ne.jp>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-sound@...r.kernel.org, Hide Hako <opi5plus@....bai.ne.jp>
Subject:
 Re: [PATCH v2] arm64: dts: rockchip: Enables sound output from the audio jack
 on OrangePI5 Plus

Hi Hide Hako,

Am Dienstag, 26. August 2025, 15:44:57 Mitteleuropäische Sommerzeit schrieb Hide Hako:
> Currently, analog sound is not output from the audio jack.
> This patch allows you to select analog headphones in alsamixer.
> Works with kernel 6.16.1, but not 6.17-rc1.
> 
> Points of concern:
> 6.16.1 kernel with ubuntu 25.04 Setting -> Sound -> Output Device
>  I select Speakers Built-in Audio, the sound will be output from the audio jack.
> 
> Changes since v1:
> - As pointed out by Jimmy, the file to be modified has been changed
>   from rk3588-orangepi-5.dtsi to rk3588-orangepi-5-plus.dts.

All of what Maud said, but also I think this deserves some

Fixes: 236d225e1ee7 ("arm64: dts: rockchip: Add board device tree for rk3588-orangepi-5-plus")

tag + could do the subject as 
  "arm64: dts: rockchip: Fix sound output from the audio jack on OrangePI5 Plus"

because this really sounds like it fixes functionality to is supposed
to be working :-)


Thanks a lot
Heiko

> Signed-off-by: Hide Hako <opi5plus@....bai.ne.jp>
> ---
>  arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
> index 121e4d1c3..44bb15951 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
> @@ -78,6 +78,7 @@ &analog_sound {
>  	pinctrl-0 = <&hp_detect>;
>  	simple-audio-card,aux-devs = <&speaker_amp>, <&headphone_amp>;
>  	simple-audio-card,hp-det-gpios = <&gpio1 RK_PD3 GPIO_ACTIVE_LOW>;
> +	simple-audio-card,pin-switches = "Speaker", "Headphones";
>  	simple-audio-card,widgets =
>  		"Microphone", "Onboard Microphone",
>  		"Microphone", "Microphone Jack",
>