linux-kernel - Re: [PATCH] platform/x86/intel/pmc: use kcalloc() instead of kzalloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <175638287905.13908.5051712719471737806.b4-ty@linux.intel.com>
Date: Thu, 28 Aug 2025 15:07:59 +0300
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Rajneesh Bhardwaj <irenic.rajneesh@...il.com>, 
 David E Box <david.e.box@...el.com>, Hans de Goede <hansg@...nel.org>, 
 platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Qianfeng Rong <rongqianfeng@...o.com>
Subject: Re: [PATCH] platform/x86/intel/pmc: use kcalloc() instead of
 kzalloc()

On Tue, 19 Aug 2025 21:51:55 +0800, Qianfeng Rong wrote:

> Replace devm_kzalloc() with devm_kcalloc() in pmc_core_get_tgl_lpm_reqs().
> As noted in the kernel documentation [1], open-coded multiplication in
> allocator arguments is discouraged because it can lead to integer
> overflow.
> 
> Using devm_kcalloc() provides built-in overflow protection, making the
> memory allocation safer when calculating the allocation size compared
> to explicit multiplication.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86/intel/pmc: use kcalloc() instead of kzalloc()
      commit: 55df384148396c0503cfc51a9c7177df6a423843

--
 i.