linux-kernel - Re: [PATCH v2 2/2] hwmon: (ina238) Add support for INA780

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e51d4b9-23fd-401b-afb1-2df943f85c3c@roeck-us.net>
Date: Thu, 28 Aug 2025 05:09:10 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Chris Packham <chris.packham@...iedtelesis.co.nz>, jdelvare@...e.com,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org
Cc: linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] hwmon: (ina238) Add support for INA780

On 8/7/25 20:05, Chris Packham wrote:
> Add support for the TI INA780 Digital Power Monitor. The INA780 uses
> EZShunt(tm) technology, which means there are fixed LSB conversions for
> a number of fields rather than needing to be calibrated.
> 
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>

Your patch does not apply, and I can't figure out its baseline. Please
reparent on top of the current mainline and resubmit.

To simplify review, the patch should be split into preparation patches
(such as adding .has_shunt and .temp_max options), followed by the actual
added chip support.

Other (not a complete review):

I don't see the value of adding INA780_COL and INA780_CUL defines;
those are really the same as the shunt voltage limits. Actually,
the current limits _are_ available for existing chips, only they
are expressed as voltage limits on the shunt voltages. For the ina_2xx
driver I was able to resolve that quite easily; we should do the same
for the ina238 driver. Maybe I have an evaluation board somewhere;
I'll need to check.

[ Sorry for being so late with this; I am being swamped at work :-( ]

Thanks,
Guenter