linux-kernel - Re: [PATCH v6 7/9] PCI: Add pcie_link_is_active() to determine if the link is active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aLBMdeZbsplpPIsX@wunner.de>
Date: Thu, 28 Aug 2025 14:32:53 +0200
From: Lukas Wunner <lukas@...ner.de>
To: Krishna Chaitanya Chundru <krishna.chundru@....qualcomm.com>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	chaitanya chundru <quic_krichai@...cinc.com>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	cros-qcom-dts-watchers@...omium.org,
	Jingoo Han <jingoohan1@...il.com>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Krzysztof Wilczy??ski <kwilczynski@...nel.org>,
	Manivannan Sadhasivam <mani@...nel.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>, quic_vbadigan@...cnic.com,
	amitk@...nel.org, linux-pci@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, jorge.ramirez@....qualcomm.com,
	linux-arm-kernel@...ts.infradead.org,
	Dmitry Baryshkov <lumag@...nel.org>,
	Shawn Anastasio <sanastasio@...torengineering.com>,
	Timothy Pearson <tpearson@...torengineering.com>
Subject: Re: [PATCH v6 7/9] PCI: Add pcie_link_is_active() to determine if
 the link is active

On Thu, Aug 28, 2025 at 05:39:04PM +0530, Krishna Chaitanya Chundru wrote:
> Add pcie_link_is_active() a common API to check if the PCIe link is active,
> replacing duplicate code in multiple locations.
> 
> Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@....qualcomm.com>
> Signed-off-by: Shawn Anastasio <sanastasio@...torengineering.com>
> Signed-off-by: Timothy Pearson <tpearson@...torengineering.com>

I think the submitter of the patch (who will become the git commit author)
needs to come last in the Signed-off-by chain.

> +++ b/drivers/pci/hotplug/pciehp_hpc.c
> @@ -614,8 +587,8 @@ static void pciehp_ignore_link_change(struct controller *ctrl,
>  	 * Synthesize it to ensure that it is acted on.
>  	 */
>  	down_read_nested(&ctrl->reset_lock, ctrl->depth);
> -	if (!pciehp_check_link_active(ctrl) || pciehp_device_replaced(ctrl))
> -		pciehp_request(ctrl, ignored_events);
> +	if (!pcie_link_is_active(ctrl_dev(ctrl)) || pciehp_device_replaced(ctrl))
> +		pciehp_request(ctrl, PCI_EXP_SLTSTA_DLLSC);
>  	up_read(&ctrl->reset_lock);
>  }

You can just use "pdev" instead of "ctrl_dev(ctrl)" as argument to
pcie_link_is_active() to shorten the line.

With that addressed,
Reviewed-by: Lukas Wunner <lukas@...ner.de>