linux-kernel - Re: [PATCH v7 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DCE2EJ3KWX3K.1Y198FHBV8UG7@google.com>
Date: Thu, 28 Aug 2025 12:37:51 +0000
From: Brendan Jackman <jackmanb@...gle.com>
To: Ujwal Kundur <ujwal.kundur@...il.com>, <akpm@...ux-foundation.org>, 
	<peterx@...hat.com>, <david@...hat.com>, <lorenzo.stoakes@...cle.com>, 
	<Liam.Howlett@...cle.com>, <vbabka@...e.cz>, <rppt@...nel.org>, 
	<surenb@...gle.com>, <mhocko@...e.com>, <shuah@...nel.org>
Cc: <linux-mm@...ck.org>, <linux-kselftest@...r.kernel.org>, 
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 1/1] selftests/mm/uffd: Refactor non-composite global
 vars into struct

On Sun Aug 17, 2025 at 6:52 AM UTC, Ujwal Kundur wrote:
> -static void noop_alias_mapping(__u64 __unused *start, size_t __unused len,
> -			       unsigned long __unused offset)
> +static void noop_alias_mapping(uffd_global_test_opts_t *gopts, __u64 __unused *start,
> +			       size_t __unused len, unsigned long __unused offset)

After a rebase this is now falling afoul of the -Wunused-parameter added
here:

https://lore.kernel.org/all/20250731160132.1795351-5-usama.anjum@collabora.com/T/#m0449dc0d6a5ac3b1f71f7182c13b6829e1b444cf

I really don't think we want that flag, I'll comment on that thread, but
just as an FYI here too.