linux-kernel - Re: [PATCH] watchdog: s3c2410: Add FSD support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad42068f-8528-4974-80cc-2f99cd628809@kernel.org>
Date: Fri, 29 Aug 2025 16:08:27 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Varada Pavani <v.pavani@...sung.com>, alim.akhtar@...sung.com,
 wim@...ux-watchdog.org, linux@...ck-us.net
Cc: linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
 gost.dev@...sung.com, aswani.reddy@...sung.com
Subject: Re: [PATCH] watchdog: s3c2410: Add FSD support

On 29/08/2025 16:00, Varada Pavani wrote:
> +
>  static const struct of_device_id s3c2410_wdt_match[] = {
>  	{ .compatible = "google,gs101-wdt",
>  	  .data = &drv_data_gs101_cl0 },
> @@ -352,6 +380,8 @@ static const struct of_device_id s3c2410_wdt_match[] = {
>  	  .data = &drv_data_exynosautov9_cl0 },
>  	{ .compatible = "samsung,exynosautov920-wdt",
>  	  .data = &drv_data_exynosautov920_cl0 },
> +	{ .compatible = "tesla,fsd-wdt",

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.


Best regards,
Krzysztof