linux-kernel - Re: [PATCH v2 1/4] mm/memory_hotplug: Update comment for hotplug memory callback priorities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250829151116.00001144@huawei.com>
Date: Fri, 29 Aug 2025 15:11:16 +0100
From: Jonathan Cameron <jonathan.cameron@...wei.com>
To: David Hildenbrand <david@...hat.com>
CC: Dave Jiang <dave.jiang@...el.com>, <linux-cxl@...r.kernel.org>,
	<linux-acpi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<gregkh@...uxfoundation.org>, <rafael@...nel.org>, <dakr@...nel.org>,
	<dave@...olabs.net>, <alison.schofield@...el.com>,
	<vishal.l.verma@...el.com>, <ira.weiny@...el.com>,
	<dan.j.williams@...el.com>, <marc.herbert@...ux.intel.com>,
	<akpm@...ux-foundation.org>
Subject: Re: [PATCH v2 1/4] mm/memory_hotplug: Update comment for hotplug
 memory callback priorities

On Thu, 21 Aug 2025 23:17:38 +0200
David Hildenbrand <david@...hat.com> wrote:

> On 20.08.25 21:47, Dave Jiang wrote:
> > Add clarification to comment for memory hotplug callback ordering as the
> > current comment does not provide clear language on which callback happens
> > first.
> > 
> > Acked-by: David Hildenbrand <david@...hat.com>
> > Signed-off-by: Dave Jiang <dave.jiang@...el.com>
> > ---
> > v2:
> > - Clearer comment suggestion from DavidH.
> > ---
> >   include/linux/memory.h | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/linux/memory.h b/include/linux/memory.h
> > index 40eb70ccb09d..de5c0d8e8925 100644
> > --- a/include/linux/memory.h
> > +++ b/include/linux/memory.h
> > @@ -115,8 +115,8 @@ struct notifier_block;
> >   struct mem_section;
> >   
> >   /*
> > - * Priorities for the hotplug memory callback routines (stored in decreasing
> > - * order in the callback chain)
> > + * Priorities for the hotplug memory callback routines. Invoked from
> > + * high to low. Higher priorities corresponds to higher numbers.  
> 
> Minor nit: s/corresponds/correspond/

With that tidied up
Reviewed-by: Jonathan Cameron <jonathan.cameron@...wei.com>

>