linux-kernel - Re: [PATCH v2 1/2] dt-bindings: phy: add support for NXPs TJA1145 CAN transceiver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a91b8fba-8d26-441e-9da6-86e302703abc@kernel.org>
Date: Fri, 29 Aug 2025 16:21:11 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: dimitri.fedrau@...bherr.com, Vinod Koul <vkoul@...nel.org>,
 Kishon Vijay Abraham I <kishon@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Dimitri Fedrau <dima.fedrau@...il.com>,
 Marc Kleine-Budde <mkl@...gutronix.de>, linux-can@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: phy: add support for NXPs TJA1145 CAN
 transceiver

On 29/08/2025 15:12, Krzysztof Kozlowski wrote:
> On 29/08/2025 11:19, Dimitri Fedrau via B4 Relay wrote:
>> From: Dimitri Fedrau <dimitri.fedrau@...bherr.com>
>>
>> Adding documentation for NXPs TJA1145 CAN transceiver.
> 
> Pity you did not include resolution of discussions about directory and
> can phy bindings here. You have entire commit msg for that, but instead
> it is a copy paste of subject.
> 
>>
>> Signed-off-by: Dimitri Fedrau <dimitri.fedrau@...bherr.com>
>> ---
>>  .../devicetree/bindings/phy/nxp,tja1145-can.yaml   | 79 ++++++++++++++++++++++
>>  1 file changed, 79 insertions(+)
> 
>>
> 
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

And un-reviewed, I missed messed example and this was never tested.

Sending untested code only makes us grumpy.

Best regards,
Krzysztof