linux-kernel - Re: [PATCH] PCI: of: Update parent unit address generation in of_pci_prop_intr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+y2dW0d3V93a3XDEhZUnw9Ky7MkvvVUzndPkur1TD=bg@mail.gmail.com>
Date: Fri, 29 Aug 2025 09:30:21 -0500
From: Rob Herring <robh@...nel.org>
To: Lorenzo Pieralisi <lpieralisi@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org, 
	devicetree@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>, 
	Lizhi Hou <lizhi.hou@....com>
Subject: Re: [PATCH] PCI: of: Update parent unit address generation in of_pci_prop_intr_map()

On Tue, Aug 19, 2025 at 8:19 AM Lorenzo Pieralisi <lpieralisi@...nel.org> wrote:
>
> On Mon, Aug 18, 2025 at 11:35:04AM +0200, Lorenzo Pieralisi wrote:
>
> [...]
>
> >  drivers/pci/of_property.c | 21 ++++++++++++++-------
> >  1 file changed, 14 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/pci/of_property.c b/drivers/pci/of_property.c
> > index 506fcd507113..09b7bc335ec5 100644
> > --- a/drivers/pci/of_property.c
> > +++ b/drivers/pci/of_property.c
> > @@ -279,13 +279,20 @@ static int of_pci_prop_intr_map(struct pci_dev *pdev, struct of_changeset *ocs,
> >                       mapp++;
> >                       *mapp = out_irq[i].np->phandle;
> >                       mapp++;
> > -                     if (addr_sz[i]) {
> > -                             ret = of_property_read_u32_array(out_irq[i].np,
> > -                                                              "reg", mapp,
> > -                                                              addr_sz[i]);
> > -                             if (ret)
> > -                                     goto failed;
> > -                     }
> > +
> > +                     /*
> > +                      * A device address does not affect the
> > +                      * device<->interrupt-controller HW connection for all
> > +                      * modern interrupt controllers; moreover, the kernel
> > +                      * (ie of_irq_parse_raw()) ignores the values in the
> > +                      * parent unit address cells while parsing the interrupt-map
> > +                      * property because they are irrelevant for interrupts mapping
> > +                      * in modern system.
>
> Rob,
>
> if you apply directly the line above should be "in modern systems" please.

But this should go via PCI tree.

Reviewed-by: Rob Herring <robh@...nel.org>