linux-kernel - Re: [PATCH] irqchip: Use int type to store negative error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <865xe6dv98.wl-maz@kernel.org>
Date: Fri, 29 Aug 2025 16:04:35 +0100
From: Marc Zyngier <maz@...nel.org>
To: Qianfeng Rong <rongqianfeng@...o.com>
Cc: Thomas Gleixner <tglx@...utronix.de>,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip: Use int type to store negative error codes

On Fri, 29 Aug 2025 14:20:19 +0100,
Qianfeng Rong <rongqianfeng@...o.com> wrote:
> 
> Change the 'ret' variable from unsigned int to int to store negative error
> codes or zero returned by other functions.
> 
> Storing the negative error codes in unsigned type, doesn't cause an issue
> at runtime but it's ugly. Additionally, assigning negative error codes to
> unsigned type may trigger a GCC warning when the -Wsign-conversion flag is
> enabled.
> 
> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>

For the GICv3 code:

Acked-by: Marc Zyngier <maz@...nel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.