linux-kernel - Re: [PATCH v2] accel/amdxdna: Use int instead of u32 to store error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d2e37d4-3ef0-4062-a693-0b73ed82a497@amd.com>
Date: Fri, 29 Aug 2025 09:02:54 -0700
From: Lizhi Hou <lizhi.hou@....com>
To: Qianfeng Rong <rongqianfeng@...o.com>, Min Ma <min.ma@....com>, "Oded
 Gabbay" <ogabbay@...nel.org>, Jeff Hugo <jeff.hugo@....qualcomm.com>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] accel/amdxdna: Use int instead of u32 to store error
 codes

Applied to drm-misc-next.

On 8/28/25 13:23, Lizhi Hou wrote:
> Reviewed-by: Lizhi Hou <lizhi.hou@....com>
>
> On 8/27/25 20:39, Qianfeng Rong wrote:
>> Change the 'ret' variable from u32 to int to store -EINVAL.  Storing the
>> negative error codes in unsigned type, doesn't cause an issue at runtime
>> but it's ugly as pants.
>>
>> Additionally, assigning -EINVAL to u32 ret (i.e., u32 ret = -EINVAL) may
>> trigger a GCC warning when the -Wsign-conversion flag is enabled.
>>
>> Fixes: aac243092b70 ("accel/amdxdna: Add command execution")
>> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
>> ---
>> v2: Modified commit message and add a fixes tag as suggested by Lizhi.
>> ---
>>   drivers/accel/amdxdna/aie2_ctx.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/accel/amdxdna/aie2_ctx.c 
>> b/drivers/accel/amdxdna/aie2_ctx.c
>> index 420467a5325c..e9f9b1fa5dc1 100644
>> --- a/drivers/accel/amdxdna/aie2_ctx.c
>> +++ b/drivers/accel/amdxdna/aie2_ctx.c
>> @@ -199,7 +199,7 @@ aie2_sched_resp_handler(void *handle, void 
>> __iomem *data, size_t size)
>>   {
>>       struct amdxdna_sched_job *job = handle;
>>       struct amdxdna_gem_obj *cmd_abo;
>> -    u32 ret = 0;
>> +    int ret = 0;
>>       u32 status;
>>         cmd_abo = job->cmd_bo;
>> @@ -229,7 +229,7 @@ static int
>>   aie2_sched_nocmd_resp_handler(void *handle, void __iomem *data, 
>> size_t size)
>>   {
>>       struct amdxdna_sched_job *job = handle;
>> -    u32 ret = 0;
>> +    int ret = 0;
>>       u32 status;
>>         if (unlikely(!data))
>> @@ -257,7 +257,7 @@ aie2_sched_cmdlist_resp_handler(void *handle, 
>> void __iomem *data, size_t size)
>>       u32 fail_cmd_status;
>>       u32 fail_cmd_idx;
>>       u32 cmd_status;
>> -    u32 ret = 0;
>> +    int ret = 0;
>>         cmd_abo = job->cmd_bo;
>>       if (unlikely(!data) || unlikely(size != sizeof(u32) * 3)) {