linux-kernel - Re: [PATCH v4 24/26] media: iris: Allocate and queue internal buffers for encoder video device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e9f86dee-3938-b9ac-4ec9-ee8ed419882a@quicinc.com>
Date: Fri, 29 Aug 2025 23:36:16 +0530
From: Dikshita Agarwal <quic_dikshita@...cinc.com>
To: Bryan O'Donoghue <bod@...nel.org>,
        Vikash Garodia
	<quic_vgarodia@...cinc.com>,
        Abhinav Kumar <abhinav.kumar@...ux.dev>,
        "Bryan
 O'Donoghue" <bryan.odonoghue@...aro.org>,
        Mauro Carvalho Chehab
	<mchehab@...nel.org>,
        Stefan Schmidt <stefan.schmidt@...aro.org>,
        "Vedang
 Nagar" <quic_vnagar@...cinc.com>,
        Hans Verkuil <hverkuil@...nel.org>
CC: <linux-media@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Renjiang Han <quic_renjiang@...cinc.com>,
        Wangao Wang <quic_wangaow@...cinc.com>,
        Neil Armstrong
	<neil.armstrong@...aro.org>
Subject: Re: [PATCH v4 24/26] media: iris: Allocate and queue internal buffers
 for encoder video device



On 8/29/2025 2:35 PM, Bryan O'Donoghue wrote:
> On 25/08/2025 08:00, Dikshita Agarwal wrote:
>> +static inline
>> +u32 size_enc_single_pipe(u32 rc_type, u32 bitbin_size, u32 num_vpp_pipes,
>> +             u32 frame_width, u32 frame_height, u32 lcu_size)
>> +{
>> +    u32 size_aligned_height = ALIGN((frame_height), lcu_size);
>> +    u32 size_aligned_width = ALIGN((frame_width), lcu_size);
>> +    u32 size_single_pipe_eval = 0, sao_bin_buffer_size = 0;
>> +    u32 padded_bin_sz;
>> +
>> +    if ((size_aligned_width * size_aligned_height) > (3840 * 2160))
>> +        size_single_pipe_eval = (bitbin_size / num_vpp_pipes);
>> +    else if (num_vpp_pipes > 2)
>> +        size_single_pipe_eval = bitbin_size / 2;
>> +    else
>> +        size_single_pipe_eval = bitbin_size;
>> +
>> +    sao_bin_buffer_size = (64 * ((((frame_width) + 32) * ((frame_height)
>> + 32)) >> 10)) + 384;
>> +    padded_bin_sz = ALIGN(size_single_pipe_eval, 256);
>> +    size_single_pipe_eval = sao_bin_buffer_size + padded_bin_sz;
>> +
>> +    return ALIGN(size_single_pipe_eval, 256);
>> +}
> 
> Applying your full series, this function is unused and causes a warning in CI.
> 
> Assuming tests pass for me, I'll be dropping this function in the PR and
> you can resubmit it if/when you find a use for it.

you're right, this is unused. Strangely I didn't see any such warnings
during my runs, but yes, this is good to be dropped.

Thanks,
Dikshita
> 
> ---
> bod