linux-kernel - Re: [PATCH v3 3/4] media: chips-media: wave5: Add WARN_ON to check if dec_output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <88fc40c386f2609584df72cf4951972b07f20e72.camel@collabora.com>
Date: Fri, 29 Aug 2025 14:15:40 -0400
From: Nicolas Dufresne <nicolas.dufresne@...labora.com>
To: "Jackson.lee" <jackson.lee@...psnmedia.com>, mchehab@...nel.org, 
	hverkuil-cisco@...all.nl, bob.beckett@...labora.com
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, 
	lafley.kim@...psnmedia.com, b-brnich@...com, hverkuil@...all.nl, 
	nas.chung@...psnmedia.com
Subject: Re: [PATCH v3 3/4] media: chips-media: wave5: Add WARN_ON to check
 if dec_output_info is NULL

Le lundi 23 juin 2025 à 09:21 +0900, Jackson.lee a écrit :
> From: Jackson Lee <jackson.lee@...psnmedia.com>
> 
> The dec_output_info could be a null pointer, so WARN_ON around it
> was added.

I think to warrant a WARN_ON, its should be that the info should NOT be null.
WARN_ON should be used for driver programming issues. If this is what you mean,
I would reword:


   The dec_output_info should not be a null pointer, WARN_ON around it to
   indicates a driver issue.


cheers,
Nicolas

> 
> Signed-off-by: Jackson Lee <jackson.lee@...psnmedia.com>
> Signed-off-by: Nas Chung <nas.chung@...psnmedia.com>
> ---
>  drivers/media/platform/chips-media/wave5/wave5-vpuapi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpuapi.c b/drivers/media/platform/chips-media/wave5/wave5-vpuapi.c
> index e94d6ebc9f81..5b10f9f49b9f 100644
> --- a/drivers/media/platform/chips-media/wave5/wave5-vpuapi.c
> +++ b/drivers/media/platform/chips-media/wave5/wave5-vpuapi.c
> @@ -485,7 +485,7 @@ int wave5_vpu_dec_get_output_info(struct vpu_instance *inst, struct dec_output_i
>  	struct vpu_device *vpu_dev = inst->dev;
>  	struct dec_output_info *disp_info;
>  
> -	if (!info)
> +	if (WARN_ON(!info))
>  		return -EINVAL;
>  
>  	p_dec_info = &inst->codec_info->dec_info;

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)