linux-kernel - Re: [PATCH 05/17] nova-core: gsp: Add support for checking if GSP reloaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a251efc542a49e95fd7b7032bdd1092253f967b4.camel@nvidia.com>
Date: Fri, 29 Aug 2025 18:44:53 +0000
From: Timur Tabi <ttabi@...dia.com>
To: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, Joel
 Fernandes <joelagnelf@...dia.com>, "dakr@...nel.org" <dakr@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Alexandre
 Courbot <acourbot@...dia.com>
CC: "joel@...lfernandes.org" <joel@...lfernandes.org>, "lossin@...nel.org"
	<lossin@...nel.org>, "ojeda@...nel.org" <ojeda@...nel.org>,
	"boqun.feng@...il.com" <boqun.feng@...il.com>, "a.hindborg@...nel.org"
	<a.hindborg@...nel.org>, "simona@...ll.ch" <simona@...ll.ch>,
	"tmgross@...ch.edu" <tmgross@...ch.edu>, "alex.gaynor@...il.com"
	<alex.gaynor@...il.com>, "tzimmermann@...e.de" <tzimmermann@...e.de>,
	"mripard@...nel.org" <mripard@...nel.org>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>, John Hubbard
	<jhubbard@...dia.com>, "rust-for-linux@...r.kernel.org"
	<rust-for-linux@...r.kernel.org>, "bjorn3_gh@...tonmail.com"
	<bjorn3_gh@...tonmail.com>, "airlied@...il.com" <airlied@...il.com>,
	"aliceryhl@...gle.com" <aliceryhl@...gle.com>, "gary@...yguo.net"
	<gary@...yguo.net>, Alistair Popple <apopple@...dia.com>
Subject: Re: [PATCH 05/17] nova-core: gsp: Add support for checking if GSP
 reloaded

On Fri, 2025-08-29 at 13:32 -0400, Joel Fernandes wrote:
> +    /// Function to check if GSP reload/resume has completed during the boot process.
> +    #[expect(dead_code)]
> +    pub(crate) fn check_reload_completed(&self, bar: &Bar0, timeout: Delta) -> Result<bool> {

I think this should be renamed to is_reload_completed() and return just bool instead of Result<bool>

> +        wait_on(timeout, || {
> +            let val = regs::NV_PGC6_BSI_SECURE_SCRATCH_14::read(bar);
> +            if val.boot_stage_3_handoff() {
> +                Some(true)
> +            } else {
> +                None
> +            }
> +        })

And if you insist on returning Result<bool>, at least have this return Some(false) or
Some(val.boot_stage_3_handoff()) instead.