linux-kernel - Re: media: mediatek: vcodec: use = { } instead of memset()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44aa36a8aaa7da22a4552b910ceb966b3a911691.camel@ndufresne.ca>
Date: Fri, 29 Aug 2025 14:57:07 -0400
From: Nicolas Dufresne <nicolas@...fresne.ca>
To: Markus Elfring <Markus.Elfring@....de>, Qianfeng Rong
	 <rongqianfeng@...o.com>, linux-media@...r.kernel.org, 
	linux-mediatek@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org
Cc: LKML <linux-kernel@...r.kernel.org>, Andrew-CT Chen	
 <andrew-ct.chen@...iatek.com>, Andrzej Pietrasiewicz
 <andrzejtp2010@...il.com>,  Angelo Gioacchino Del Regno
 <angelogioacchino.delregno@...labora.com>, Hans Verkuil
 <hverkuil@...nel.org>, Matthias Brugger	 <matthias.bgg@...il.com>, Mauro
 Carvalho Chehab <mchehab@...nel.org>, Neil Armstrong
 <neil.armstrong@...aro.org>, Tiffany Lin <tiffany.lin@...iatek.com>, Yunfei
 Dong	 <yunfei.dong@...iatek.com>
Subject: Re: media: mediatek: vcodec: use = { } instead of memset()

Le mardi 05 août 2025 à 15:32 +0200, Markus Elfring a écrit :
> > > …
> > > > This patch converts …
> > > See also once more:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16#n94
> > I don't think your point is a problem here. …
> 
> Will any contributors care more for the usage of imperative mood
> also according to improved change descriptions?

Markus, its the way you review that does not work. I'm far from perfect, so I
don't normally give any lesson, but I've seen this this exact interaction too
often. Try suggesting a rephrase instead.

Qianfeng Rong, the suggestion is that:

   This patch converts memset() to = { }, thereby:
   
Can be rephrased:

   Converts memset() to = { }, thereby:

Also, some maintainers may prefer if you swap the two paraphs, so you get to the
point first, and give context in the remaining. Processing tones of patches is
improved if you don't have to read the entire message to understand what the
patch is doing at high level.

regards,
Nicolas

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)