linux-kernel - Re: [PATCH v3 3/4] iio: adc: ad7124: add external clock support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vf8fAFin1tJ-yjr22RPuDgBEBnj6JO3GkjDcZsmYoOfYA@mail.gmail.com>
Date: Fri, 29 Aug 2025 22:11:12 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: David Lechner <dlechner@...libre.com>
Cc: Michael Hennerich <Michael.Hennerich@...log.com>, Jonathan Cameron <jic23@...nel.org>, 
	Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, linux-iio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/4] iio: adc: ad7124: add external clock support

On Fri, Aug 29, 2025 at 8:19 PM David Lechner <dlechner@...libre.com> wrote:
> On 8/29/25 10:53 AM, Andy Shevchenko wrote:
> > On Fri, Aug 29, 2025 at 12:55 AM David Lechner <dlechner@...libre.com> wrote:

...

> >> +                       if (clk_hz > MEGA) {
> >
> > I read your answer, but maybe I missed something?  Can we use (1 *
> > HZ_PER_MHZ) here?
>
> I suppose we can. But it doesn't add any additional information.
> We already know we are dealing with Hz because of clk_hz and 1
> is implicit. So it is just a matter of style preference. Since I
> read a lot of code, I tend to prefer the minimal approach - it is
> less to read and still has the same meaning.

Physicist in me prefers pedantism in comparison of the units. We don't
compare kilometers with kilograms (maybe not the best example, though,
if you understand what I mean :-).

> >> +                               clk_sel = AD7124_ADC_CONTROL_CLK_SEL_EXT_DIV4;
> >> +                               st->clk_hz = clk_hz / 4;
> >> +                       } else {
> >> +                               clk_sel = AD7124_ADC_CONTROL_CLK_SEL_EXT;
> >> +                               st->clk_hz = clk_hz;
> >> +                       }


-- 
With Best Regards,
Andy Shevchenko