linux-kernel - Re: [PATCH 06/12] mm/util: add `const` to several pointer parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aLIzWR5IQr7D3wBa@fedora>
Date: Fri, 29 Aug 2025 16:10:17 -0700
From: "Vishal Moola (Oracle)" <vishal.moola@...il.com>
To: Max Kellermann <max.kellermann@...os.com>
Cc: akpm@...ux-foundation.org, david@...hat.com, axelrasmussen@...gle.com,
	yuanchu@...gle.com, willy@...radead.org, hughd@...gle.com,
	mhocko@...e.com, linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com, vbabka@...e.cz,
	rppt@...nel.org, surenb@...gle.com
Subject: Re: [PATCH 06/12] mm/util: add `const` to several pointer parameters

On Fri, Aug 29, 2025 at 08:31:53PM +0200, Max Kellermann wrote:
> For improved const-correctness.
> 
> Signed-off-by: Max Kellermann <max.kellermann@...os.com>
> --- a/include/linux/pagemap.h
> +++ b/include/linux/pagemap.h
> @@ -549,7 +549,7 @@ static inline void filemap_nr_thps_dec(struct address_space *mapping)
>  #endif
>  }
>  
> -struct address_space *folio_mapping(struct folio *);
> +struct address_space *folio_mapping(const struct folio *);

Can we make this (const struct folio *folio) like below. Its more
readable imo.

With or without that change, feel free to add:
Reviewed-by: Vishal Moola (Oracle) <vishal.moola@...il.com>

> +struct address_space *folio_mapping(const struct folio *folio)
>  {
>  	struct address_space *mapping;
>