linux-kernel - Re: [PATCH v2] block/mq-deadline: Remove the redundant rb_entry_rq in the deadline_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d6702b7c-a674-6fb8-f326-acbd87b148bb@huaweicloud.com>
Date: Fri, 29 Aug 2025 14:16:04 +0800
From: Li Nan <linan666@...weicloud.com>
To: chengkaitao <pilgrimtao@...il.com>, axboe@...nel.dk
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
 chengkaitao <chengkaitao@...inos.cn>
Subject: Re: [PATCH v2] block/mq-deadline: Remove the redundant rb_entry_rq in
 the deadline_from_pos().



在 2025/8/29 11:45, chengkaitao 写道:
> From: chengkaitao <chengkaitao@...inos.cn>
> 
> In commit(fde02699c242), the "if (blk_rq_is_seq_zoned_write(rq))"
> was removed, but the "rb_entry_rq(node)" and some other code were
> inadvertently left behind. This patch fixed it.
> 
> Signed-off-by: chengkaitao <chengkaitao@...inos.cn>
> ---
>   block/mq-deadline.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/block/mq-deadline.c b/block/mq-deadline.c
> index 1a031922c447..63145cc9825f 100644
> --- a/block/mq-deadline.c
> +++ b/block/mq-deadline.c
> @@ -133,10 +133,6 @@ static inline struct request *deadline_from_pos(struct dd_per_prio *per_prio,
>   	struct rb_node *node = per_prio->sort_list[data_dir].rb_node;
>   	struct request *rq, *res = NULL;
>   
> -	if (!node)
> -		return NULL;
> -
> -	rq = rb_entry_rq(node);
>   	while (node) {
>   		rq = rb_entry_rq(node);
>   		if (blk_rq_pos(rq) >= pos) {

LGTM

Reviewed-by: Li Nan <linan122@...wei.com>

-- 
Thanks,
Nan