linux-kernel - Re: [PATCH] arm64: dts: xilinx: Drop undocumented "always-on" properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ca5b18a-96bc-41da-8784-171116d75b50@topic.nl>
Date: Fri, 29 Aug 2025 08:25:40 +0200
From: Mike Looijmans <mike.looijmans@...ic.nl>
To: Michal Simek <michal.simek@....com>, "Rob Herring (Arm)"
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
CC: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: xilinx: Drop undocumented "always-on"
 properties

On 29-08-2025 07:46, Michal Simek wrote:
> Hi,
>
> On 8/28/25 23:30, Rob Herring (Arm) wrote:
>> The "always-on" properties are not documented for "silabs,si5341"
>> binding nor used by the Linux driver, so drop them.
>
> Binding
> Documentation/devicetree/bindings/clock/silabs,si5341.txt
> doesn't contain it
> but driver drivers/clk/clk-si5341.c is reading it.
>
> 1345                 config[num].always_on =
> 1346                         of_property_read_bool(child, "always-on");
>
> It is there from 2019 when driver has been added.
>
> If it is not standard clock property it should be moved to standard one.

Agree - either "always-on" should become a standard property, or it should be 
removed from the driver.

As a standard property, akin to "regulator-always-on", maybe it should 
probably be renamed to "clock-always-on"?

I'd be happy to provide a patch either way.


> And DT binding should be converted to yaml with all properties used today.
>
> Thanks,
> Michal
>
>
Mike.