linux-kernel - Re: [PATCH] selftests/bpf: Upon failures, exit with code 1 in test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ8uoz2US3EtXe17E2Rq6J+pkHe0TqiN9S8dM9npGaRskQo5QQ@mail.gmail.com>
Date: Fri, 29 Aug 2025 09:09:45 +0200
From: Magnus Karlsson <magnus.karlsson@...il.com>
To: Ricardo B. Marlière <rbm@...e.com>
Cc: Björn Töpel <bjorn@...nel.org>, 
	Magnus Karlsson <magnus.karlsson@...el.com>, 
	Maciej Fijalkowski <maciej.fijalkowski@...el.com>, Jonathan Lemon <jonathan.lemon@...il.com>, 
	Stanislav Fomichev <sdf@...ichev.me>, Andrii Nakryiko <andrii@...nel.org>, 
	Eduard Zingerman <eddyz87@...il.com>, Mykola Lysenko <mykolal@...com>, Alexei Starovoitov <ast@...nel.org>, 
	Daniel Borkmann <daniel@...earbox.net>, Martin KaFai Lau <martin.lau@...ux.dev>, Song Liu <song@...nel.org>, 
	Yonghong Song <yonghong.song@...ux.dev>, John Fastabend <john.fastabend@...il.com>, 
	KP Singh <kpsingh@...nel.org>, Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>, 
	Shuah Khan <shuah@...nel.org>, netdev@...r.kernel.org, bpf@...r.kernel.org, 
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/bpf: Upon failures, exit with code 1 in test_xsk.sh

On Thu, 28 Aug 2025 at 20:48, Ricardo B. Marlière <rbm@...e.com> wrote:
>
> Currently, even if some subtests fails, the end result will still yield
> "ok 1 selftests: bpf: test_xsk.sh". Fix it by exiting with 1 if there are
> any failures.
>
> Signed-off-by: Ricardo B. Marlière <rbm@...e.com>

Thanks Ricardo.

Acked-by: Magnus Karlsson <magnus.karlsson@...el.com>

> ---
>  tools/testing/selftests/bpf/test_xsk.sh | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/bpf/test_xsk.sh b/tools/testing/selftests/bpf/test_xsk.sh
> index 65aafe0003db054e9dfd156092fed53b07be06a0..62db060298a4a3b4391ee4cfa50557cf4a62d3d5 100755
> --- a/tools/testing/selftests/bpf/test_xsk.sh
> +++ b/tools/testing/selftests/bpf/test_xsk.sh
> @@ -241,4 +241,6 @@ done
>
>  if [ $failures -eq 0 ]; then
>          echo "All tests successful!"
> +else
> +       exit 1
>  fi
>
> ---
> base-commit: 5b6d6fe1ca7b712c74f78426bb23c465fd34b322
> change-id: 20250828-selftests-bpf-test_xsk_ret-1eb27dbac071
>
> Best regards,
> --
> Ricardo B. Marlière <rbm@...e.com>
>
>