linux-kernel - Re: [PATCH V7 0/5] Add support for QCOM SPMI PMIC5 Gen3 ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250829-imaginary-dove-of-music-afdb36@kuoka>
Date: Fri, 29 Aug 2025 09:11:07 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Jishnu Prakash <jishnu.prakash@....qualcomm.com>
Cc: jic23@...nel.org, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, agross@...nel.org, andersson@...nel.org, lumag@...nel.org, 
	dmitry.baryshkov@....qualcomm.com, konradybcio@...nel.org, daniel.lezcano@...aro.org, 
	sboyd@...nel.org, amitk@...nel.org, thara.gopinath@...il.com, lee@...nel.org, 
	rafael@...nel.org, subbaraman.narayanamurthy@....qualcomm.com, 
	david.collins@....qualcomm.com, anjelique.melendez@....qualcomm.com, 
	kamal.wadhwa@....qualcomm.com, rui.zhang@...el.com, lukasz.luba@....com, 
	devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org, linux-iio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org, cros-qcom-dts-watchers@...omium.org, 
	quic_kotarake@...cinc.com, neil.armstrong@...aro.org, stephan.gerhold@...aro.org
Subject: Re: [PATCH V7 0/5] Add support for QCOM SPMI PMIC5 Gen3 ADC

On Tue, Aug 26, 2025 at 02:06:52PM +0530, Jishnu Prakash wrote:
> PMIC5 Gen3 has a similar ADC architecture to that on PMIC5 Gen2,
> with all SW communication to ADC going through PMK8550 which
> communicates with other PMICs through PBS. The major difference is
> that the register interface used here is that of an SDAM present on
> PMK8550, rather than a dedicated ADC peripheral. There may be more than one
> SDAM used for ADC5 Gen3. Each ADC SDAM has eight channels, each of which may
> be used for either immediate reads (same functionality as previous PMIC5 and
> PMIC5 Gen2 ADC peripherals) or recurring measurements (same as PMIC5 and PMIC5
> Gen2 ADC_TM functionality). In this case, we have VADC and ADC_TM functionality
> combined into the same driver.
> 
> Patch 1 is a cleanup, to move the QCOM ADC dt-bindings files from
> dt-bindings/iio to dt-bindings/iio/adc folder, as they are
> specifically for ADC devices. It also fixes all compilation errors
> with this change in driver and devicetree files and similar errors
> in documentation for dtbinding check.
> 
> Patch 2 splits out the common ADC channel properties used on older
> VADC devices, which would also be reused on ADC5 Gen3.
> 
> Patch 3 adds bindings for ADC5 Gen3 peripheral.
> 
> Patch 4 adds the main driver for ADC5 Gen3.
> 
> Patch 5 adds the auxiliary thermal driver which supports the ADC_TM
> functionality of ADC5 Gen3.
> 
> Changes since v6:
> - Updated auxiliary device cleanup handling to fix memory freeing issues
> - Updated copyright license in newly added files

Eveyrthing is an update.... What did you change in copyright and
license? And why?

> - Addressed some reviewer comments in documentation and driver patches.

What changed specifically?

> - Link to v6: https://lore.kernel.org/all/20250509110959.3384306-1-jishnu.prakash@oss.qualcomm.com/
> 

Best regards,
Krzysztof