linux-kernel - RE: [PATCH v2] wifi: rtw89: use int type to store negative error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <872a02f45c5241eaa124f0899d9946b2@realtek.com>
Date: Fri, 29 Aug 2025 00:31:04 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Qianfeng Rong <rongqianfeng@...o.com>,
        "linux-wireless@...r.kernel.org"
	<linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] wifi: rtw89: use int type to store negative error codes

Qianfeng Rong <rongqianfeng@...o.com> wrote:
> The 'ret' variable stores returns from other functions, which return
> either zero on success or negative error codes on failure.  Storing
> error codes in u32 (an unsigned type) causes no runtime issues but is
> stylistically inconsistent and very ugly.  Change 'ret' from u32 to
> int - this has no runtime impact.
> 
> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>

Acked-by: Ping-Ke Shih <pkshih@...ltek.com>