linux-kernel - Re: [PATCH V7 5/5] thermal: qcom: add support for PMIC5 Gen3 ADC thermal monitoring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250829-helpful-clay-hoatzin-acb8b1@kuoka>
Date: Fri, 29 Aug 2025 09:14:17 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Jishnu Prakash <jishnu.prakash@....qualcomm.com>
Cc: jic23@...nel.org, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, agross@...nel.org, andersson@...nel.org, lumag@...nel.org, 
	dmitry.baryshkov@....qualcomm.com, konradybcio@...nel.org, daniel.lezcano@...aro.org, 
	sboyd@...nel.org, amitk@...nel.org, thara.gopinath@...il.com, lee@...nel.org, 
	rafael@...nel.org, subbaraman.narayanamurthy@....qualcomm.com, 
	david.collins@....qualcomm.com, anjelique.melendez@....qualcomm.com, 
	kamal.wadhwa@....qualcomm.com, rui.zhang@...el.com, lukasz.luba@....com, 
	devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org, linux-iio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org, cros-qcom-dts-watchers@...omium.org, 
	quic_kotarake@...cinc.com, neil.armstrong@...aro.org, stephan.gerhold@...aro.org
Subject: Re: [PATCH V7 5/5] thermal: qcom: add support for PMIC5 Gen3 ADC
 thermal monitoring

On Tue, Aug 26, 2025 at 02:06:57PM +0530, Jishnu Prakash wrote:
> Add support for ADC_TM part of PMIC5 Gen3.
> 
> This is an auxiliary driver under the Gen3 ADC driver, which implements the
> threshold setting and interrupt generating functionalities of QCOM ADC_TM
> drivers, used to support thermal trip points.
> 
> Signed-off-by: Jishnu Prakash <jishnu.prakash@....qualcomm.com>
> ---
> Changes since v6:
> - Addressed minor reviewer comments.

No, reviewers comments are not minor. Your change can be minor.

Anyway this is just vague. `b4 diff` fails, so your changelog must be
precise.

Best regards,
Krzysztof