linux-kernel - Re: [PATCH v4 1/4] dt-bindings: reset: add Tegra114 car header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250829-hot-spicy-puma-c9a9b3@kuoka>
Date: Fri, 29 Aug 2025 09:29:21 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Mikko Perttunen <mperttunen@...dia.com>
Cc: Svyatoslav Ryhel <clamor95@...il.com>, 
	Thierry Reding <thierry.reding@...il.com>, Thierry Reding <treding@...dia.com>, 
	Jonathan Hunter <jonathanh@...dia.com>, Prashant Gaikwad <pgaikwad@...dia.com>, 
	Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
	Philipp Zabel <p.zabel@...gutronix.de>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org, 
	linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH v4 1/4] dt-bindings: reset: add Tegra114 car header

On Thu, Aug 28, 2025 at 04:50:03PM +0900, Mikko Perttunen wrote:
> > > 
> > >  include/dt-bindings/reset/tegra114-car.h | 13 +++++++++++++
> > >  1 file changed, 13 insertions(+)
> > >  create mode 100644 include/dt-bindings/reset/tegra114-car.h
> > > 
> > > diff --git a/include/dt-bindings/reset/tegra114-car.h
> > > b/include/dt-bindings/reset/tegra114-car.h new file mode 100644
> > > index 000000000000..d7908d810ddf
> > > --- /dev/null
> > > +++ b/include/dt-bindings/reset/tegra114-car.h
> > 
> > Still incorrectly named. Use full compatible, just like the other file
> > where we already switched to recommended format (see also writing bindings).
> > 
> > I asked for this at v1 and then reminded about unresolved comments at v3.
> > 
> 
> Ah, I guess you mean using 'nvidia,tegra114-car.h'? At least I hadn't realized 
> practice had changed to include the vendor prefix.

That practice is VERY old. For example first patches from my subsystem
are around 2015. It is true, though, that we ask for this since 3-4
years. In the upstream Linux kernel 3-4 years is also very long time,
though...

> 
> It can be said that 'tegra114-car.h' is also based on the compatible, so I 
> hadn't quite understood the original comment.

With that approach "tegra114.h" or "t.h" is also based on the compatible.

Best regards,
Krzysztof