linux-kernel - Re: [PATCH v4 06/10] dt-bindings: clock: Add required "interconnect-cells" property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250829-ubiquitous-imaginary-mammoth-d52bde@kuoka>
Date: Fri, 29 Aug 2025 09:37:02 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Luo Jie <quic_luoj@...cinc.com>
Cc: Bjorn Andersson <andersson@...nel.org>, 
	Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
	Varadarajan Narayanan <quic_varada@...cinc.com>, Georgi Djakov <djakov@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Anusha Rao <quic_anusha@...cinc.com>, Manikanta Mylavarapu <quic_mmanikan@...cinc.com>, 
	Devi Priya <quic_devipriy@...cinc.com>, Philipp Zabel <p.zabel@...gutronix.de>, 
	Richard Cochran <richardcochran@...il.com>, Konrad Dybcio <konradybcio@...nel.org>, 
	Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, linux-arm-msm@...r.kernel.org, 
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org, 
	devicetree@...r.kernel.org, netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	quic_kkumarcs@...cinc.com, quic_linchen@...cinc.com, quic_leiwei@...cinc.com, 
	quic_pavir@...cinc.com, quic_suruchia@...cinc.com
Subject: Re: [PATCH v4 06/10] dt-bindings: clock: Add required
 "interconnect-cells" property

On Thu, Aug 28, 2025 at 06:32:19PM +0800, Luo Jie wrote:
> ICC clocks are always provided by the NSS clock controller of IPQ9574,
> so add interconnect-cells as required DT property.

Does not make sense. If clocks are always, you require different
property?

> 
> Fixes: 28300ecedce4 ("dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions")
> Signed-off-by: Luo Jie <quic_luoj@...cinc.com>

Fixes cannot be in the middle of patchset.

See submitting patches and your internal guideline explaining it with
great details.

> ---
>  Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
> index 17252b6ea3be..fc604279114f 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
> @@ -57,6 +57,7 @@ required:
>    - compatible
>    - clocks
>    - clock-names
> +  - '#interconnect-cells'

ABI break without explanation.

Best regards,
Krzysztof