linux-kernel - Re: [PATCH v3 2/2] arm64: dts: qcom: Add Monaco EVK initial board support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250829-clever-analytic-pudu-96cda0@kuoka>
Date: Fri, 29 Aug 2025 09:59:49 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Umang Chheda <umang.chheda@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>, 
	Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Richard Cochran <richardcochran@...il.com>, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Rakesh Kota <rakesh.kota@....qualcomm.com>, 
	Nirmesh Kumar Singh <quic_nkumarsi@...cinc.com>, Viken Dadhaniya <viken.dadhaniya@....qualcomm.com>, 
	Mohd Ayaan Anwar <quic_mohdayaa@...cinc.com>, Arun Khannna <quic_arkhanna@...cinc.com>, 
	Monish Chunara <quic_mchunara@...cinc.com>, Vikash Garodia <quic_vgarodia@...cinc.com>, 
	Swati Agarwal <swati.agarwal@....qualcomm.com>
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: Add Monaco EVK initial board
 support

On Tue, Aug 26, 2025 at 11:45:06PM +0530, Umang Chheda wrote:
> +&i2c1 {
> +	pinctrl-0 = <&qup_i2c1_default>;
> +	pinctrl-names = "default";
> +
> +	status = "okay";
> +
> +	eeprom0: eeprom@50 {
> +		compatible = "atmel,24c256";
> +		reg = <0x50>;
> +		pagesize = <64>;
> +
> +		nvmem-layout {
> +			compatible = "fixed-layout";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +
> +			mac_addr0: mac-addr@0 {
> +				reg = <0x0 0x6>;
> +			};
> +		};
> +	};
> +};
> +
> +&i2c15 {
> +	pinctrl-0 = <&qup_i2c15_default>;
> +	pinctrl-names = "default";
> +
> +	status = "okay";
> +
> +	expander0: pca953x@38 {

Same problem as in all other recent qcom boards.

I heard that some teams in qcom have weekly meetings and discuss what
did they learn from upstream review.

Please organize/join such meetings.

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel
sources for similar cases or you can grow the spec (via pull request to
DT spec repo).

Best regards,
Krzysztof