linux-kernel - Re: [PATCH v3 2/3] coresight-tnoc: add platform driver to support Interconnect TNOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250829082427.GF745921@e132581.arm.com>
Date: Fri, 29 Aug 2025 09:24:27 +0100
From: Leo Yan <leo.yan@....com>
To: Yuanfang Zhang <yuanfang.zhang@....qualcomm.com>
Cc: Suzuki K Poulose <suzuki.poulose@....com>,
	Mike Leach <mike.leach@...aro.org>,
	James Clark <james.clark@...aro.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	kernel@....qualcomm.com, coresight@...ts.linaro.org,
	linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/3] coresight-tnoc: add platform driver to support
 Interconnect TNOC

On Thu, Aug 28, 2025 at 02:27:23AM -0700, Yuanfang Zhang wrote:

[...]

> @@ -51,12 +53,17 @@ static void trace_noc_enable_hw(struct trace_noc_drvdata *drvdata)
>  {
>  	u32 val;
>  
> +	/* No valid ATID, simply enable the unit */
> +	if (drvdata->atid == -EOPNOTSUPP) {
> +		writel(TRACE_NOC_CTRL_PORTEN, drvdata->base + TRACE_NOC_CTRL);
> +		return;
> +	}
> +
>  	/* Set ATID */
>  	writel_relaxed(drvdata->atid, drvdata->base + TRACE_NOC_XLD);
>  
>  	/* Set the data word count between 'SYNC' packets */
>  	writel_relaxed(TRACE_NOC_SYNC_INTERVAL, drvdata->base + TRACE_NOC_SYNCR);
> -

Unintended change ?

>  	/* Set the Control register:
>  	 * - Set the FLAG packets to 'FLAG' packets
>  	 * - Set the FREQ packets to 'FREQ_TS' packets
> @@ -68,8 +75,8 @@ static void trace_noc_enable_hw(struct trace_noc_drvdata *drvdata)
>  	val &= ~TRACE_NOC_CTRL_FLAGTYPE;
>  	val |= TRACE_NOC_CTRL_FREQTYPE;
>  	val |= TRACE_NOC_CTRL_PORTEN;
> -

Ditto.

>  	writel(val, drvdata->base + TRACE_NOC_CTRL);
> +

Ditto.

Otherwise, LGTM:

Reviewed-by: Leo Yan <leo.yan@....com>