linux-kernel - Re: [PATCH net-next 1/2] net: pse-pd: pd692x0: Separate configuration parsing from hardware setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250829102624.1d959943@kmaincent-XPS-13-7390>
Date: Fri, 29 Aug 2025 10:26:24 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Oleksij Rempel <o.rempel@...gutronix.de>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 kernel@...gutronix.de, Dent Project <dentproject@...uxfoundation.org>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, Maxime Chevallier
 <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH net-next 1/2] net: pse-pd: pd692x0: Separate
 configuration parsing from hardware setup

On Thu, 28 Aug 2025 15:12:18 -0700
Jakub Kicinski <kuba@...nel.org> wrote:

> On Thu, 28 Aug 2025 10:46:12 +0200 Kory Maincent wrote:
> > > On Fri, 22 Aug 2025 17:37:01 +0200 Kory Maincent wrote:    
>  [...]  
> > > 
> > > Leaking manager..    
> > 
> > I don't think so, as manager is declared like the following it should not.
> > struct pd692x0_manager *manager __free(kfree) = NULL;  
> 
> Please consult documentation on the user of __free() within networking.

Oh, I didn't know about this net policy.
I didn't follow the maintainer-netdev doc changes. Maybe I should.
Ok, I will add a patch to the series to remove the __free macro. 

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com