linux-kernel - Re: [PATCH] net: wwan: iosm: use int type to store negative error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ca0967a9-b97f-4e7e-bbaf-55251a995c79@maciej.szmigiero.name>
Date: Fri, 29 Aug 2025 11:01:48 +0200
From: "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
To: Qianfeng Rong <rongqianfeng@...o.com>
Cc: Loic Poulain <loic.poulain@....qualcomm.com>,
 Sergey Ryazanov <ryazanov.s.a@...il.com>,
 Johannes Berg <johannes@...solutions.net>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: wwan: iosm: use int type to store negative error
 codes

On 26.08.2025 15:50, Qianfeng Rong wrote:
> The 'ret' variable in ipc_pcie_resources_request() either stores '-EBUSY'
> directly or holds returns from pci_request_regions() and ipc_acquire_irq().
> Storing negative error codes in u32 causes no runtime issues but is
> stylistically inconsistent and very ugly.  Change 'ret' from u32 to int
> type - this has no runtime impact.
> 
> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
> ---
>   drivers/net/wwan/iosm/iosm_ipc_pcie.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wwan/iosm/iosm_ipc_pcie.c b/drivers/net/wwan/iosm/iosm_ipc_pcie.c
> index a066977af0be..08ff0d6ccfab 100644
> --- a/drivers/net/wwan/iosm/iosm_ipc_pcie.c
> +++ b/drivers/net/wwan/iosm/iosm_ipc_pcie.c
> @@ -69,7 +69,7 @@ static int ipc_pcie_resources_request(struct iosm_pcie *ipc_pcie)
>   {
>   	struct pci_dev *pci = ipc_pcie->pci;
>   	u32 cap = 0;
> -	u32 ret;
> +	int ret;
>   
>   	/* Reserved PCI I/O and memory resources.
>   	 * Mark all PCI regions associated with PCI device pci as

Reviewed-by: Maciej S. Szmigiero <maciej.szmigiero@...cle.com>

Thanks,
Maciej