linux-kernel - Re: [PATCH] serial: 8250_of: replace kzalloc with devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27562003-b129-4dea-818c-2e81176f842b@gmail.com>
Date: Fri, 29 Aug 2025 11:49:41 +0200
From: Osama Abdelkader <osama.abdelkader@...il.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: jirislaby@...nel.org, andriy.shevchenko@...ux.intel.com,
 elder@...cstar.com, benjamin.larsson@...exis.eu,
 u.kleine-koenig@...libre.com, linux-kernel@...r.kernel.org,
 linux-serial@...r.kernel.org
Subject: Re: [PATCH] serial: 8250_of: replace kzalloc with devm_kzalloc

On 8/28/25 7:51 AM, Greg KH wrote:
> On Thu, Aug 28, 2025 at 01:11:05AM +0200, Osama Abdelkader wrote:
>> Use devm_kzalloc for automatic memory cleanup.
> Why?
>
> I do not see a good reason here as to how this makes anything better
> overall?  How was it tested?
>
> thanks,
>
> greg k-h

Hi Greg,

Thanks for the feedback, the change to devm_kzalloc ensures the allocated
memory is tied to the device's lifetime. This removed the need for explicit
kfree() calls in the remove path and avoids potential leaks in probe error 
paths. It also aligns the driver with others in the 8250 subsystem which 
already use devm-managed resources.

For testing, I built the kernel and booted it on QEMU riscv with of_serial
enabled. The driver probed successfully and the serial console worked as
expected, also tested unbinding/rebinding the driver via sysfs to confirm
no leaks or errors occur.

Thanks,
Osama