linux-kernel - Re: 回复: 回复: 回复: 回复: [PATCH 1/3] pinctrl: cix: Add pin-controller support for sky1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4879398b-a24c-4ec6-8bb0-90d2c1db2dc8@kernel.org>
Date: Fri, 29 Aug 2025 12:35:50 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Gary Yang <gary.yang@...tech.com>,
 "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
 "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
 <krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>
Cc: "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 cix-kernel-upstream <cix-kernel-upstream@...tech.com>
Subject: Re: 回复: 回复: 回复: 回复: [PATCH 1/3] pinctrl: cix: Add pin-controller support for sky1

On 29/08/2025 12:18, Gary Yang wrote:
>>>
>>> So you see the twice, once per one pin-controller. BTW as you suggested
>> before, we will print the value of ret in the error message.
>>>
>>> If I miss any information, please kindly remind me. Thanks
>>
>> You still ignored my second comment.

^^^ That was second time here I reminded about ENOMEM comment.

>>
> 
> First you wrote " You are printing same error twice ", please pay attention to the "same error" strings, it makes me confuse, I misunderstand your thinking 
> until you took the example above. So the discussion is needed, not waste our time.
> 
> Second the return value of sky1_pinctrl_probe_dt() is not only ENOMEM, it can also return ENODEV and EINVAL. Although I don't think this is a bug, take our

The problem is that you ignored the ENOMEM comment and it clearly should
direct you to the problem and solution ("If I cannot have error on
ENOMEM, I will move my error msgs to the called function").

Best regards,
Krzysztof