linux-kernel - Re: [PATCH 2/2] selftests: Replace relative includes with non-relative for kselftest.h and kselftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250829105306.6638-1-reddybalavignesh9979@gmail.com>
Date: Fri, 29 Aug 2025 16:23:06 +0530
From: Bala-Vignesh-Reddy <reddybalavignesh9979@...il.com>
To: richard.weiyang@...il.com
Cc: Liam.Howlett@...cle.com,
	akpm@...ux-foundation.org,
	davem@...emloft.net,
	david@...hat.com,
	edumazet@...gle.com,
	gnoack@...gle.com,
	horms@...nel.org,
	kuba@...nel.org,
	linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org,
	linux-mm@...ck.org,
	linux-security-module@...r.kernel.org,
	lorenzo.stoakes@...cle.com,
	mhocko@...e.com,
	mic@...ikod.net,
	ming.lei@...hat.com,
	pabeni@...hat.com,
	reddybalavignesh9979@...il.com,
	rppt@...nel.org,
	shuah@...nel.org,
	skhan@...uxfoundation.org,
	surenb@...gle.com,
	vbabka@...e.cz
Subject: Re: [PATCH 2/2] selftests: Replace relative includes with non-relative for kselftest.h and kselftest_harness.h

>+ifeq ($(KSFT_INCLUDES),)
>+KSFT_INCLUDES := -I../
>+endif
>+

This makes sense, but if we do it for mm/ then we have to
follow this for all subdirectories in selftests.. that might
cause problems if subdirectories are nested ones likes filesystems/.
Duplicating this across all subdir Makefile adds churn and can
lead to errors.

Another way, is adding `CFLAGS += -I../` as is done in net/Makefile,
but this also doesn't solve the problem completely as this also
remain to relative addressing.

But, if preferred we can add this snippet in Makefile to
resolve the error temporarily.

Thanks,
Bala Vignesh