linux-kernel - RE: [PATCH 1/4] arm64: dts: exynos5433: Add default GIC address cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <263b01dc18d4$8b9b33d0$a2d19b70$@samsung.com>
Date: Fri, 29 Aug 2025 16:33:24 +0530
From: "Alim Akhtar" <alim.akhtar@...sung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>, "'Ivaylo
 Ivanov'" <ivo.ivanov.ivanov1@...il.com>, "'Rob Herring'" <robh@...nel.org>,
	"'Krzysztof Kozlowski'" <krzk+dt@...nel.org>, "'Conor Dooley'"
	<conor+dt@...nel.org>, "'Peter Griffin'" <peter.griffin@...aro.org>,
	'André Draszik' <andre.draszik@...aro.org>, "'Tudor
 Ambarus'" <tudor.ambarus@...aro.org>, <linux-fsd@...la.com>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-samsung-soc@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/4] arm64: dts: exynos5433: Add default GIC address
 cells

Hi Krzysztof

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Friday, August 22, 2025 5:44 PM
> To: Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>; Rob Herring
> <robh@...nel.org>; Krzysztof Kozlowski <krzk+dt@...nel.org>; Conor
> Dooley <conor+dt@...nel.org>; Alim Akhtar <alim.akhtar@...sung.com>;
> Peter Griffin <peter.griffin@...aro.org>; André Draszik
> <andre.draszik@...aro.org>; Tudor Ambarus <tudor.ambarus@...aro.org>;
> linux-fsd@...la.com; linux-arm-kernel@...ts.infradead.org; linux-samsung-
> soc@...r.kernel.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Subject: [PATCH 1/4] arm64: dts: exynos5433: Add default GIC address cells
> 
> Add missing address-cells 0 to GIC interrupt node to silence W=1
> warning:
> 
>   exynos5433-tm2-common.dtsi:1000.2-41: Warning (interrupt_map):
> /soc@...cie@...00000:interrupt-map:
>     Missing property '#address-cells' in node /soc@...nterrupt-
> controller@...01000, using 0 as fallbac
> 
> Value '0' is correct because:
> 1. GIC interrupt controller does not have children, 2. interrupt-map property
> (in PCI node) consists of five components and
>    the fourth component "parent unit address", which size is defined by
>    '#address-cells' of the node pointed to by the interrupt-parent
>    component, is not used (=0).
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>

>  arch/arm64/boot/dts/exynos/exynos5433.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index 0b9053b9b2b5..fa2029e280a5 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -937,6 +937,7 @@ reboot: syscon-reboot {
> 
>  		gic: interrupt-controller@...01000 {
>  			compatible = "arm,gic-400";
> +			#address-cells = <0>;
>  			#interrupt-cells = <3>;
>  			interrupt-controller;
>  			reg = <0x11001000 0x1000>,
> --
> 2.48.1