linux-kernel - Re: [PATCH v3 2/3] power: supply: Add bd718(15/28/78) charger driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6f56b7b6-8b21-4353-bbca-acf7f9b42ceb@gmail.com>
Date: Fri, 29 Aug 2025 15:27:18 +0300
From: Matti Vaittinen <mazziesaccount@...il.com>
To: Linus Walleij <linus.walleij@...aro.org>,
 Andreas Kemnade <andreas@...nade.info>
Cc: Lee Jones <lee@...nel.org>, Sebastian Reichel <sre@...nel.org>,
 linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
 Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [PATCH v3 2/3] power: supply: Add bd718(15/28/78) charger driver

On 29/08/2025 09:35, Matti Vaittinen wrote:

>> Some of these look like they should immediately shut down the
>> system, I suppose the battery charger does this autonomously
>> but it should probably also trigger an emergency shutdown
>> of Linux, right?
> 
> Yes. The shutdown for charging, or, in some cases for all power outputs, 
> is automatically handled by the PMIC hardware. (Well, I am not sure 
> about the 'over-current' IRQ, will see if I can find out more about it).

Just to conclude this - I got a confirmation from the ROHM hardware 
engineers that exceeding the set limit and causing the over-current and 
the coulomb counter monitoring interrupts do not change the hardware 
charging state. [CC_MON and OCUR events in the data sheet, if someone 
has that ;) ].

The CC_MON1 will however cause a change in the charging LED state. Eg, 
exceeding this limit will turn off the AMBLED and turn on the GRNLED - 
when the LEDs are controlled by the HW state machine. (I have some very 
faint memory that the LEDs could also be forced ON by software). I 
suppose the reason for this is that the CC_MON1 was designed to be used 
as a "coulomb counter near full capacity" alarm.

Yours,
	-- Matti