linux-kernel - Re: [PATCH v5 1/3] arm64: topology: Set scale freq source only for the CPUs that have not been set before

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c64d1999-9070-0d1d-35a7-9f2c55f39fc8@hisilicon.com>
Date: Sat, 30 Aug 2025 12:08:20 +0800
From: Jie Zhan <zhanjie9@...ilicon.com>
To: Lifeng Zheng <zhenglifeng1@...wei.com>, <catalin.marinas@....com>,
	<will@...nel.org>, <rafael@...nel.org>, <viresh.kumar@...aro.org>,
	<beata.michalska@....com>, <sudeep.holla@....com>
CC: <linux-arm-kernel@...ts.infradead.org>, <linux-pm@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linuxarm@...wei.com>,
	<jonathan.cameron@...wei.com>, <vincent.guittot@...aro.org>,
	<yangyicong@...ilicon.com>, <lihuisong@...wei.com>, <yubowen8@...wei.com>,
	<zhangpengjie2@...wei.com>, <linhongye@...artners.com>
Subject: Re: [PATCH v5 1/3] arm64: topology: Set scale freq source only for
 the CPUs that have not been set before



On 19/08/2025 15:29, Lifeng Zheng wrote:
> The scale freq source of the CPUs in 'amu_fie_cpus' mask are already set to
> AMU tick before, so in amu_fie_setup(), only the CPUs in the 'cpus' mask
> should be set.
> 
LGTM.

Reviewed-by: Jie Zhan <zhanjie9@...ilicon.com>
> Signed-off-by: Lifeng Zheng <zhenglifeng1@...wei.com>
> ---
>  arch/arm64/kernel/topology.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c
> index 5d07ee85bdae..9317a618bb87 100644
> --- a/arch/arm64/kernel/topology.c
> +++ b/arch/arm64/kernel/topology.c
> @@ -373,7 +373,7 @@ static void amu_fie_setup(const struct cpumask *cpus)
>  
>  	cpumask_or(amu_fie_cpus, amu_fie_cpus, cpus);
>  
> -	topology_set_scale_freq_source(&amu_sfd, amu_fie_cpus);
> +	topology_set_scale_freq_source(&amu_sfd, cpus);
>  
>  	pr_debug("CPUs[%*pbl]: counters will be used for FIE.",
>  		 cpumask_pr_args(cpus));