linux-kernel - Re: [PATCH 1/2] iio: adc: Add driver for Marvell 88PM886 PMIC ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vd+hAucOyjqLj=rY3oLSySiReVupRQdBjwoLQSPAZMNMQ@mail.gmail.com>
Date: Sat, 30 Aug 2025 07:41:58 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: David Lechner <dlechner@...libre.com>
Cc: Duje Mihanović <duje@...emihanovic.xyz>, 
	Jonathan Cameron <jic23@...nel.org>, Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, Karel Balej <balejk@...fyz.cz>, Lee Jones <lee@...nel.org>, 
	David Wronek <david@...nlining.org>, phone-devel@...r.kernel.org, 
	~postmarketos/upstreaming@...ts.sr.ht, linux-kernel@...r.kernel.org, 
	linux-iio@...r.kernel.org
Subject: Re: [PATCH 1/2] iio: adc: Add driver for Marvell 88PM886 PMIC ADC

On Sat, Aug 30, 2025 at 7:37 AM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Fri, Aug 29, 2025 at 2:41 AM David Lechner <dlechner@...libre.com> wrote:
> > On 8/28/25 5:17 PM, Duje Mihanović wrote:

...


> > > +     ret = regmap_bulk_read(*map, regs[chan], buf, 2);

On top, please drop a double pointer and use map directly. That's
already a pointer, what's the issue with it to begin with?

> sizeof()
>
> > > +
>
> Redundant blank line.
>
> > > +     if (ret)
> > > +             return ret;

-- 
With Best Regards,
Andy Shevchenko