linux-kernel - Re: [RFC 8/8] powerpc/book3s64/slb: Add slb faults to vmstat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y0r1jtki.fsf@gmail.com>
Date: Sat, 30 Aug 2025 10:26:45 +0530
From: Ritesh Harjani (IBM) <ritesh.list@...il.com>
To: Stephen Rothwell <sfr@...b.auug.org.au>
Cc: linuxppc-dev@...ts.ozlabs.org, Madhavan Srinivasan <maddy@...ux.ibm.com>, Michael Ellerman <mpe@...erman.id.au>, Nicholas
 Piggin <npiggin@...il.com>, Christophe Leroy <christophe.leroy@...roup.eu>, Donet Tom <donettom@...ux.ibm.com>, Andrew Morton <akpm@...ux-foundation.org>, David Hildenbrand <david@...hat.com>, Lorenzo
 Stoakes <lorenzo.stoakes@...cle.com>, linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [RFC 8/8] powerpc/book3s64/slb: Add slb faults to vmstat

Stephen Rothwell <sfr@...b.auug.org.au> writes:

> Hi Ritesh,
>
> On Sat, 30 Aug 2025 09:21:47 +0530 "Ritesh Harjani (IBM)" <ritesh.list@...il.com> wrote:
>>
>> diff --git a/mm/vmstat.c b/mm/vmstat.c
>> index 71cd1ceba191..8cd17a5fc72b 100644
>> --- a/mm/vmstat.c
>> +++ b/mm/vmstat.c
>> @@ -1464,6 +1464,11 @@ const char * const vmstat_text[] = {
>>  	[I(DIRECT_MAP_LEVEL2_COLLAPSE)]		= "direct_map_level2_collapses",
>>  	[I(DIRECT_MAP_LEVEL3_COLLAPSE)]		= "direct_map_level3_collapses",
>>  #endif
>> +#ifdef CONFIG_PPC_BOOK3S_64
>> +	"slb_kernel_faults",
>> +	"slb_user_faults",
>> +#endif
>> +
>>  #ifdef CONFIG_PER_VMA_LOCK_STATS
>>  	[I(VMA_LOCK_SUCCESS)]			= "vma_lock_success",
>>  	[I(VMA_LOCK_ABORT)]			= "vma_lock_abort",
>
> Should you be using explicit indexes and the I() macro?

Aah yes, I guess the branch where I developed the patches was not
upstream tip and when I rebased and tested, I missed to see the I()
macro change in mm/vmstat. 

Thanks Stephen for pointing it out. I will fix that in the next revision.

-ritesh

>
> -- 
> Cheers,
> Stephen Rothwell