| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20250831-icm20948-v1-5-1fe560a38de4@gmail.com>
Date: Sun, 31 Aug 2025 00:12:49 +0530
From: Bharadwaj Raju <bharadwaj.raju777@...il.com>
To: Jonathan Cameron <jic23@...nel.org>,
David Lechner <dlechner@...libre.com>,
Nuno Sá <nuno.sa@...log.com>,
Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, shuah@...nel.org,
linux-kernel-mentees@...ts.linux.dev,
Bharadwaj Raju <bharadwaj.raju777@...il.com>
Subject: [PATCH 5/5] iio: imu: icm20948: add runtime power management
support
Implement runtime power management support for the ICM20948
sensor. The device autosuspends after 2 seconds of idle time.
Signed-off-by: Bharadwaj Raju <bharadwaj.raju777@...il.com>
---
drivers/iio/imu/inv_icm20948/Makefile | 1 +
drivers/iio/imu/inv_icm20948/inv_icm20948.h | 7 +++
drivers/iio/imu/inv_icm20948/inv_icm20948_core.c | 3 +-
drivers/iio/imu/inv_icm20948/inv_icm20948_gyro.c | 28 ++++++---
drivers/iio/imu/inv_icm20948/inv_icm20948_power.c | 73 +++++++++++++++++++++++
drivers/iio/imu/inv_icm20948/inv_icm20948_temp.c | 15 +++--
6 files changed, 114 insertions(+), 13 deletions(-)
diff --git a/drivers/iio/imu/inv_icm20948/Makefile b/drivers/iio/imu/inv_icm20948/Makefile
index 88a37be159e1d6f575da1c070c84ac94cd963020..0a17ad1c003e6a93f3431f7a998e56cdf975d245 100644
--- a/drivers/iio/imu/inv_icm20948/Makefile
+++ b/drivers/iio/imu/inv_icm20948/Makefile
@@ -4,6 +4,7 @@ obj-$(CONFIG_INV_ICM20948) += inv-icm20948.o
inv-icm20948-y += inv_icm20948_core.o
inv-icm20948-y += inv_icm20948_temp.o
inv-icm20948-y += inv_icm20948_gyro.o
+inv-icm20948-y += inv_icm20948_power.o
obj-$(CONFIG_INV_ICM20948_I2C) += inv-icm20948-i2c.o
inv-icm20948-i2c-y += inv_icm20948_i2c.o
diff --git a/drivers/iio/imu/inv_icm20948/inv_icm20948.h b/drivers/iio/imu/inv_icm20948/inv_icm20948.h
index ca2513114378cdcba5bc315fc94cd61f930b4dfa..194dcccabc2162334779b285320187c7ff1f5236 100644
--- a/drivers/iio/imu/inv_icm20948/inv_icm20948.h
+++ b/drivers/iio/imu/inv_icm20948/inv_icm20948.h
@@ -13,10 +13,13 @@
#include <linux/i2c.h>
#include <linux/iio/iio.h>
#include <linux/err.h>
+ #include <linux/pm_runtime.h>
/* accel takes 20ms, gyro takes 35ms to wake from full-chip sleep */
#define INV_ICM20948_SLEEP_WAKEUP_MS 35
+ #define INV_ICM20948_SUSPEND_DELAY_MS 2000
+
#define INV_ICM20948_REG_BANK_SEL 0x7F
#define INV_ICM20948_BANK_SEL_MASK GENMASK(5, 4)
@@ -46,6 +49,8 @@
extern const struct regmap_config inv_icm20948_regmap_config;
+extern const struct dev_pm_ops inv_icm20948_pm_ops;
+
enum inv_icm20948_gyro_fs {
INV_ICM20948_GYRO_FS_250 = 0,
INV_ICM20948_GYRO_FS_500 = 1,
@@ -82,4 +87,6 @@ extern int inv_icm20948_core_probe(struct regmap *regmap);
struct iio_dev *inv_icm20948_temp_init(struct inv_icm20948_state *state);
struct iio_dev *inv_icm20948_gyro_init(struct inv_icm20948_state *state);
+int inv_icm20948_pm_setup(struct inv_icm20948_state *state);
+
#endif
diff --git a/drivers/iio/imu/inv_icm20948/inv_icm20948_core.c b/drivers/iio/imu/inv_icm20948/inv_icm20948_core.c
index eb4f940de7013bf4ddeb69b6380a60fbde49964a..e6e670d96e40c3663e55d1545b52f609603a02ed 100644
--- a/drivers/iio/imu/inv_icm20948/inv_icm20948_core.c
+++ b/drivers/iio/imu/inv_icm20948/inv_icm20948_core.c
@@ -101,7 +101,7 @@ static int inv_icm20948_setup(struct inv_icm20948_state *state)
if (IS_ERR(state->gyro_dev))
return PTR_ERR(state->gyro_dev);
- return 0;
+ return inv_icm20948_pm_setup(state);
}
int inv_icm20948_core_probe(struct regmap *regmap)
@@ -113,6 +113,7 @@ int inv_icm20948_core_probe(struct regmap *regmap)
state = devm_kzalloc(dev, sizeof(*state), GFP_KERNEL);
if (!state)
return -ENOMEM;
+ dev_set_drvdata(dev, state);
state->regmap = regmap;
state->dev = dev;
diff --git a/drivers/iio/imu/inv_icm20948/inv_icm20948_gyro.c b/drivers/iio/imu/inv_icm20948/inv_icm20948_gyro.c
index 2d4d598eb21c8ce98d4ee3c72504554ab49ea596..9cefb47a46b1a323202aa84f0de647d7b7b89728 100644
--- a/drivers/iio/imu/inv_icm20948/inv_icm20948_gyro.c
+++ b/drivers/iio/imu/inv_icm20948/inv_icm20948_gyro.c
@@ -73,10 +73,14 @@ static const struct iio_chan_spec inv_icm20948_gyro_channels[] = {
static int inv_icm20948_gyro_apply_config(struct inv_icm20948_state *state)
{
guard(mutex)(&state->lock);
+ pm_runtime_get_sync(state->dev);
- return regmap_write_bits(state->regmap, INV_ICM20948_REG_GYRO_CONFIG_1,
+ int ret = regmap_write_bits(state->regmap, INV_ICM20948_REG_GYRO_CONFIG_1,
INV_ICM20948_GYRO_CONFIG_FULLSCALE,
state->gyro_conf->fsr << 1);
+
+ pm_runtime_put_autosuspend(state->dev);
+ return ret;
}
static int inv_icm20948_gyro_read_sensor(struct inv_icm20948_state *state,
@@ -99,23 +103,25 @@ static int inv_icm20948_gyro_read_sensor(struct inv_icm20948_state *state,
return -EINVAL;
}
+ pm_runtime_get_sync(state->dev);
+
__be16 raw;
int ret = regmap_bulk_read(state->regmap, reg, &raw, sizeof(raw));
if (ret)
- return ret;
+ goto out;
*val = (s16)be16_to_cpu(raw);
- return 0;
+out:
+ pm_runtime_put_autosuspend(state->dev);
+ return ret;
}
static int inv_icm20948_gyro_read_calibbias(struct inv_icm20948_state *state,
struct iio_chan_spec const *chan,
int *val, int *val2)
{
- guard(mutex)(&state->lock);
-
unsigned int reg;
switch (chan->channel2) {
@@ -133,8 +139,11 @@ static int inv_icm20948_gyro_read_calibbias(struct inv_icm20948_state *state,
}
__be16 offset_raw;
+
+ pm_runtime_get_sync(state->dev);
int ret = regmap_bulk_read(state->regmap, reg, &offset_raw,
sizeof(offset_raw));
+ pm_runtime_put_autosuspend(state->dev);
if (ret)
return ret;
@@ -216,8 +225,6 @@ static int inv_icm20948_write_calibbias(struct inv_icm20948_state *state,
struct iio_chan_spec const *chan,
int val, int val2)
{
- guard(mutex)(&state->lock);
-
unsigned int reg;
switch (chan->channel2) {
@@ -246,8 +253,13 @@ static int inv_icm20948_write_calibbias(struct inv_icm20948_state *state,
s16 offset = clamp(offset64, (s64)S16_MIN, (s64)S16_MAX);
__be16 offset_write = cpu_to_be16(offset);
- return regmap_bulk_write(state->regmap, reg, &offset_write,
+ pm_runtime_get_sync(state->dev);
+ mutex_lock(&state->lock);
+ int ret = regmap_bulk_write(state->regmap, reg, &offset_write,
sizeof(offset_write));
+ mutex_unlock(&state->lock);
+ pm_runtime_put_autosuspend(state->dev);
+ return ret;
}
static int inv_icm20948_gyro_write_raw(struct iio_dev *gyro_dev,
diff --git a/drivers/iio/imu/inv_icm20948/inv_icm20948_power.c b/drivers/iio/imu/inv_icm20948/inv_icm20948_power.c
new file mode 100644
index 0000000000000000000000000000000000000000..1281a5e5acb539cd3f91ca8ed8d52371f330b60a
--- /dev/null
+++ b/drivers/iio/imu/inv_icm20948/inv_icm20948_power.c
@@ -0,0 +1,73 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (C) 2025 Bharadwaj Raju <bharadwaj.raju777@...il.com>
+ */
+
+#include "inv_icm20948.h"
+
+static int inv_icm20948_suspend(struct device *dev)
+{
+ if (pm_runtime_suspended(dev))
+ return 0;
+
+ struct inv_icm20948_state *state = dev_get_drvdata(dev);
+
+ guard(mutex)(&state->lock);
+
+ return regmap_write_bits(state->regmap, INV_ICM20948_REG_PWR_MGMT_1,
+ INV_ICM20948_PWR_MGMT_1_SLEEP,
+ INV_ICM20948_PWR_MGMT_1_SLEEP);
+}
+
+static int inv_icm20948_resume(struct device *dev)
+{
+ struct inv_icm20948_state *state = dev_get_drvdata(dev);
+
+ guard(mutex)(&state->lock);
+
+ pm_runtime_disable(state->dev);
+ pm_runtime_set_active(state->dev);
+ pm_runtime_enable(state->dev);
+
+ int ret = regmap_write_bits(state->regmap, INV_ICM20948_REG_PWR_MGMT_1,
+ INV_ICM20948_PWR_MGMT_1_SLEEP, 0);
+ if (ret)
+ return ret;
+
+ msleep(INV_ICM20948_SLEEP_WAKEUP_MS);
+
+ return 0;
+}
+
+static void inv_icm20948_pm_disable(void *data)
+{
+ struct device *dev = data;
+
+ pm_runtime_put_sync(dev);
+ pm_runtime_disable(dev);
+}
+
+int inv_icm20948_pm_setup(struct inv_icm20948_state *state)
+{
+ struct device *dev = state->dev;
+
+ guard(mutex)(&state->lock);
+
+ int ret;
+
+ ret = pm_runtime_set_active(dev);
+ if (ret)
+ return ret;
+ pm_runtime_get_noresume(dev);
+ pm_runtime_enable(dev);
+ pm_runtime_set_autosuspend_delay(dev, INV_ICM20948_SUSPEND_DELAY_MS);
+ pm_runtime_use_autosuspend(dev);
+ pm_runtime_put(dev);
+
+ return devm_add_action_or_reset(dev, inv_icm20948_pm_disable, dev);
+}
+
+EXPORT_NS_GPL_DEV_PM_OPS(inv_icm20948_pm_ops, IIO_ICM20948) = {
+ SYSTEM_SLEEP_PM_OPS(inv_icm20948_suspend, inv_icm20948_resume)
+ RUNTIME_PM_OPS(inv_icm20948_suspend, inv_icm20948_resume, NULL)
+};
diff --git a/drivers/iio/imu/inv_icm20948/inv_icm20948_temp.c b/drivers/iio/imu/inv_icm20948/inv_icm20948_temp.c
index 916053740cc5acda0316c76504d4086eff5ec7f0..6e17b3719301d6d7f005d545587f558fcadd2f40 100644
--- a/drivers/iio/imu/inv_icm20948/inv_icm20948_temp.c
+++ b/drivers/iio/imu/inv_icm20948/inv_icm20948_temp.c
@@ -24,17 +24,24 @@ static const struct iio_chan_spec
static int inv_icm20948_temp_read_sensor(struct inv_icm20948_state *state,
s16 *temp)
{
- guard(mutex)(&state->lock);
+ int ret;
+
+ pm_runtime_get_sync(state->dev);
+ mutex_lock(&state->lock);
__be16 raw;
- int ret = regmap_bulk_read(state->regmap, INV_ICM20948_REG_TEMP_DATA,
+ ret = regmap_bulk_read(state->regmap, INV_ICM20948_REG_TEMP_DATA,
&raw, sizeof(raw));
if (ret)
- return ret;
+ goto out;
*temp = __be16_to_cpu(raw);
+ ret = 0;
- return 0;
+out:
+ mutex_unlock(&state->lock);
+ pm_runtime_put_autosuspend(state->dev);
+ return ret;
}
static int inv_icm20948_temp_read_raw(struct iio_dev *temp_dev,
--
2.51.0
Powered by blists - more mailing lists