linux-kernel - Re: [PATCH v2] drm/rockchip: analogix_dp: Apply devm_clk_get_optional() for &rockchip_dp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <vtpva7fgzwgde3sgtjir4ckns2yak7kmrumgccutwbupyqxyjt@zmxbatrhiaoo>
Date: Sat, 30 Aug 2025 22:55:58 +0200
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Damon Ding <damon.ding@...k-chips.com>
Cc: heiko@...ech.de, andy.yan@...k-chips.com, hjc@...k-chips.com, 
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, 
	simona@...ll.ch, dmitry.baryshkov@....qualcomm.com, 
	dri-devel@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org, 
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drm/rockchip: analogix_dp: Apply
 devm_clk_get_optional() for &rockchip_dp_device.grfclk

Hi,

On Sun, Aug 24, 2025 at 02:54:41PM +0800, Damon Ding wrote:
> The "grf" clock is optional for Rockchip eDP controller(RK3399 needs
> while RK3288 and RK3588 do not).
> 
> It can make the code more consice to use devm_clk_get_optional()
> instead of devm_clk_get() with extra checks.
> 
> In addtion, DRM_DEV_ERROR() is replaced by dev_err_probe().
> 
> Signed-off-by: Damon Ding <damon.ding@...k-chips.com>
> 
> ------

Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.com>

-- Sebastian

> 
> Changes in v2:
> - Replace DRM_DEV_ERROR() with dev_err_probe().
> ---
>  drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> index d30f0983a53a..937f83cf42fc 100644
> --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> @@ -335,15 +335,9 @@ static int rockchip_dp_of_probe(struct rockchip_dp_device *dp)
>  		return PTR_ERR(dp->grf);
>  	}
>  
> -	dp->grfclk = devm_clk_get(dev, "grf");
> -	if (PTR_ERR(dp->grfclk) == -ENOENT) {
> -		dp->grfclk = NULL;
> -	} else if (PTR_ERR(dp->grfclk) == -EPROBE_DEFER) {
> -		return -EPROBE_DEFER;
> -	} else if (IS_ERR(dp->grfclk)) {
> -		DRM_DEV_ERROR(dev, "failed to get grf clock\n");
> -		return PTR_ERR(dp->grfclk);
> -	}
> +	dp->grfclk = devm_clk_get_optional(dev, "grf");
> +	if (IS_ERR(dp->grfclk))
> +		return dev_err_probe(dev, PTR_ERR(dp->grfclk), "failed to get grf clock\n");
>  
>  	dp->pclk = devm_clk_get(dev, "pclk");
>  	if (IS_ERR(dp->pclk)) {
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)