linux-kernel - Re: [PATCH] platform/x86: asus-wmi: Fix racy registrations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250830033816.1762169f@mir>
Date: Sat, 30 Aug 2025 03:38:16 +0200
From: Stefan Lippers-Hollmann <s.l-h@....de>
To: Takashi Iwai <tiwai@...e.de>
Cc: "Luke D . Jones" <luke@...nes.dev>, Corentin Chary
 <corentin.chary@...il.com>, Hans de Goede <hansg@...nel.org>, Ilpo
 Järvinen <ilpo.jarvinen@...ux.intel.com>, Jiri Slaby
 <jirislaby@...nel.org>, platform-driver-x86@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: asus-wmi: Fix racy registrations

Hi

On 2025-08-27, Takashi Iwai wrote:
> asus_wmi_register_driver() may be called from multiple drivers
> concurrently, which can lead to the racy list operations, eventually
> corrupting the memory and hitting Oops on some ASUS machines.
> Also, the error handling is missing, and it forgot to unregister ACPI
> lps0 dev ops in the error case.
[...]

Thank you very much for this patch, it fixes the v6.16.x regression for 
me (my own git bisecting failed more than four times, due to false 
negatives) :)

Confirmed to work on:
- ASUS PRIME B760M-A WIFI D4, i7-13700
- ASUS TUF GAMING B760M-PLUS WIFI D4, i5-12400

Regards
	Stefan Lippers-Hollmann