linux-kernel - Re: [PATCH] cramfs: Verify inode mode when loading from disk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5n9rqorq-5o43-q195-s28p-p8r5s1o23s92@syhkavp.arg>
Date: Fri, 29 Aug 2025 22:27:55 -0400 (EDT)
From: Nicolas Pitre <nico@...xnic.net>
To: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
cc: LKML <linux-kernel@...r.kernel.org>, 
    Christian Brauner <brauner@...nel.org>, 
    Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] cramfs: Verify inode mode when loading from disk

On Fri, 29 Aug 2025, Tetsuo Handa wrote:

> Any questions? Should I find someone who can take this patch?

Please add

Acked-by: Nicolas Pitre <nico@...xnic.net>

and send it to linux-fsdevel@...r.kernel.org.

> On 2025/08/12 23:52, Tetsuo Handa wrote:
> > The inode mode loaded from corrupted disk can be invalid. Do like what
> > commit 0a9e74051313 ("isofs: Verify inode mode when loading from disk")
> > does.
> > 
> > Reported-by: syzbot <syzbot+895c23f6917da440ed0d@...kaller.appspotmail.com>
> > Closes: https://syzkaller.appspot.com/bug?extid=895c23f6917da440ed0d
> > Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> > ---
> >  fs/cramfs/inode.c | 11 ++++++++++-
> >  1 file changed, 10 insertions(+), 1 deletion(-)
> > 
> > diff --git a/fs/cramfs/inode.c b/fs/cramfs/inode.c
> > index b002e9b734f9..12daa85ed941 100644
> > --- a/fs/cramfs/inode.c
> > +++ b/fs/cramfs/inode.c
> > @@ -116,9 +116,18 @@ static struct inode *get_cramfs_inode(struct super_block *sb,
> >  		inode_nohighmem(inode);
> >  		inode->i_data.a_ops = &cramfs_aops;
> >  		break;
> > -	default:
> > +	case S_IFCHR:
> > +	case S_IFBLK:
> > +	case S_IFIFO:
> > +	case S_IFSOCK:
> >  		init_special_inode(inode, cramfs_inode->mode,
> >  				old_decode_dev(cramfs_inode->size));
> > +		break;
> > +	default:
> > +		printk(KERN_DEBUG "CRAMFS: Invalid file type 0%04o for inode %lu.\n",
> > +		       inode->i_mode, inode->i_ino);
> > +		iget_failed(inode);
> > +		return ERR_PTR(-EIO);
> >  	}
> >  
> >  	inode->i_mode = cramfs_inode->mode;
> 
>