linux-kernel - Re: [PATCH v6 0/4] Add IIO backend support for AD7779

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250831133738.5ba540c7@jic23-huawei>
Date: Sun, 31 Aug 2025 13:37:38 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Ioana Risteiu <Ioana.Risteiu@...log.com>, Lars-Peter Clausen
 <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, Nuno
 Sá <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Ramona Nechita
 <ramona.nechita@...log.com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 0/4] Add IIO backend support for AD7779

On Tue, 26 Aug 2025 11:24:26 -0500
David Lechner <dlechner@...libre.com> wrote:

> On 8/25/25 5:13 PM, Ioana Risteiu wrote:
> >   - Add axi_adc_num_lanes_set in the adi_axi_adc_ops structure to support
> >   setting number of lanes used by AXI ADC.
> >   - Add the generic io-backends property to the AD7779 binding to enable
> >   support for the IIO backend framework.
> >   - Add the adi,num-lanes property to set the number of lanes used by
> >   AD7779.
> >   - Move the initialization specific to communication without iio-backend
> >   into a separate setup function.
> >   - Add a new functionality to ad7779 driver that streams data through data
> >   output interface using IIO backend interface.  
> 
> It is more helpful for the cover letter to contain a high-level
> overview of why you want this series included in the kernel. We
> can look at the individual patches to see what they are about, so
> repeating that here isn't especially helpful.
> 
> For example, I would write the cover letter for this series like this:
> 
> The AD7779 ADC chip has a secondary data bus for high-speed data
> transfers. To make use of this bus, it is connected to an FPGA IP
> core [1] which is handled using the IIO backend framework. This IP
> core connects to the data bus lines as well as the data ready signal
> on the ADC. This interface can use 1, 2 or 4 lanes at a time.
> 
> This series extends the devicetree bindings to describe these wiring
> configuration, extends the IIO backend framework to allow setting the
> number of lanes that are being used, and extends the ad7779 driver to
> allow using such a backend for reading data in buffered reads.
> 
> [1]: https://analogdevicesinc.github.io/hdl/projects/ad777x_fmcz/index.html
> 
> > 
> > Ioana Risteiu (4):
> >   iio: adc: adi-axi-adc: add axi_adc_num_lanes_set
> >   dt-bindings: iio: adc: add IIO backend support
> >   iio: adc: extract setup function without backend
> >   iio: adc: update ad7779 to use IIO backend
> > 
> >  .../bindings/iio/adc/adi,ad7779.yaml          |  44 +++-
> >  drivers/iio/adc/ad7779.c                      | 192 ++++++++++++++----
> >  drivers/iio/adc/adi-axi-adc.c                 |   1 +
> >  3 files changed, 196 insertions(+), 41 deletions(-)
> >   
> 
> Please include a changelog of what was changed in each revision of
> the series along with links to the previous revisions. Tools like
> b4 can help automate this.
> 
> https://docs.kernel.org/6.16/process/submitting-patches.html
Whilst I fully agree with this, please keep the per patch change logs
as well as personally I find those more useful.  For those just
changes from previous version is fine.

Anyhow, other than this process stuff the series looks good to me
so applied to the togreg branch of iio.git and pushed out as testing.

Thanks,

Jonathan